From dee4f488b1317a0e1eb2be39411bcaf0b1e7618a Mon Sep 17 00:00:00 2001 From: Vinit Badrike Date: Wed, 12 Apr 2023 22:12:20 -0700 Subject: [PATCH] Updates as per reviewer comments --- hack/README.md | 3 ++- hack/update-gofmt.sh | 2 +- hack/verify-gofmt.sh | 2 +- 3 files changed, 4 insertions(+), 3 deletions(-) mode change 100644 => 100755 hack/verify-gofmt.sh diff --git a/hack/README.md b/hack/README.md index eaf01ea37..03ffb0370 100644 --- a/hack/README.md +++ b/hack/README.md @@ -149,7 +149,8 @@ pushing directly to a local registry and configuring kind to use this reg, so do isnt required. - Or a `tilt` recipe which hot reloads all kpng on code changes. - +## Code formating +**We should run `hack/verify-gofmt.sh` before submitting a PR it checks whether the source code needs to be formatted or not and if anything fails run `hack/update-gofmt.sh` to actually format sources**. diff --git a/hack/update-gofmt.sh b/hack/update-gofmt.sh index 176472d24..9f366ed41 100644 --- a/hack/update-gofmt.sh +++ b/hack/update-gofmt.sh @@ -1,6 +1,6 @@ #!/usr/bin/env bash -# Copyright 2014 The Kubernetes Authors. +# Copyright 2023 The Kubernetes Authors. # # Licensed under the Apache License, Version 2.0 (the "License"); # you may not use this file except in compliance with the License. diff --git a/hack/verify-gofmt.sh b/hack/verify-gofmt.sh old mode 100644 new mode 100755 index 9bad68bf1..e00fb3c40 --- a/hack/verify-gofmt.sh +++ b/hack/verify-gofmt.sh @@ -1,6 +1,6 @@ #!/usr/bin/env bash -# Copyright 2021 The Kubernetes Authors. +# Copyright 2023 The Kubernetes Authors. # # Licensed under the Apache License, Version 2.0 (the "License"); # you may not use this file except in compliance with the License.