Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Squid helm chart should offer Deployement label setting #91

Open
tmeltser opened this issue Nov 7, 2022 · 1 comment
Open

Squid helm chart should offer Deployement label setting #91

tmeltser opened this issue Nov 7, 2022 · 1 comment

Comments

@tmeltser
Copy link

tmeltser commented Nov 7, 2022

Currently there is no option in the helm chart to add label to the deployment (or rather to the pods of the deployment), and it is needed in some cases.

I suggest to add the following:
values.yaml:
.
.
.

podLabels:
  some-label-name-1: some-label-value-1
  some-label-name-2: some-label-value-2

deployment.yaml:

spec:
.
.
.
  template:
    metadata:
      labels:
        app: {{ template "squid.name" . }}
        release: {{ .Release.Name }}
        **{{- if .Values.podLabels }}
          {{ toYaml .Values.podLabels | indent 8 }}
        {{- end }}**
@tmeltser
Copy link
Author

tmeltser commented Nov 7, 2022

I'm ready with a PR if someone is willing to review and integrate it...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant