From eacd60c87d3d219794f0f1cb9ffede649915d31e Mon Sep 17 00:00:00 2001 From: "dependabot-preview[bot]" <27856297+dependabot-preview[bot]@users.noreply.github.com> Date: Fri, 7 Aug 2020 16:38:48 +0200 Subject: [PATCH 1/5] :arrow_up::lock: Bump elliptic from 6.4.1 to 6.5.3 (#491) Bumps [elliptic](https://github.com/indutny/elliptic) from 6.4.1 to 6.5.3. **This update includes a security fix.** - [Release notes](https://github.com/indutny/elliptic/releases) - [Commits](https://github.com/indutny/elliptic/compare/v6.4.1...v6.5.3) Signed-off-by: dependabot-preview[bot] Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> --- package-lock.json | 80 +++++++++++++++++++++++++---------------------- 1 file changed, 43 insertions(+), 37 deletions(-) diff --git a/package-lock.json b/package-lock.json index 593f7ae79..443145312 100644 --- a/package-lock.json +++ b/package-lock.json @@ -4379,9 +4379,9 @@ }, "dependencies": { "@babel/runtime": { - "version": "7.10.5", - "resolved": "https://registry.npmjs.org/@babel/runtime/-/runtime-7.10.5.tgz", - "integrity": "sha512-otddXKhdNn7d0ptoFRHtMLa8LqDxLYwTjB4nYgM1yy5N6gU/MUf8zqyyLltCH3yAVitBzmwK4us+DD0l/MauAg==", + "version": "7.11.0", + "resolved": "https://registry.npmjs.org/@babel/runtime/-/runtime-7.11.0.tgz", + "integrity": "sha512-qArkXsjJq7H+T86WrIFV0Fnu/tNOkZ4cgXmjkzAu3b/58D5mFIO8JH/y77t7C9q0OdDRdh9s7Ue5GasYssxtXw==", "dev": true, "requires": { "regenerator-runtime": "^0.13.4" @@ -4771,9 +4771,9 @@ } }, "open": { - "version": "7.0.4", - "resolved": "https://registry.npmjs.org/open/-/open-7.0.4.tgz", - "integrity": "sha512-brSA+/yq+b08Hsr4c8fsEW2CRzk1BmfN3SAK/5VCHQ9bdoZJ4qa/+AfR0xHjlbbZUyPkUHs1b8x1RqdyZdkVqQ==", + "version": "7.1.0", + "resolved": "https://registry.npmjs.org/open/-/open-7.1.0.tgz", + "integrity": "sha512-lLPI5KgOwEYCDKXf4np7y1PBEkj7HYIyP2DY8mVDRnx0VIIu6bNrRB0R66TuO7Mack6EnTNLm4uvcl1UoklTpA==", "dev": true, "requires": { "is-docker": "^2.0.0", @@ -4790,9 +4790,9 @@ } }, "parse-json": { - "version": "5.0.0", - "resolved": "https://registry.npmjs.org/parse-json/-/parse-json-5.0.0.tgz", - "integrity": "sha512-OOY5b7PAEFV0E2Fir1KOkxchnZNCdowAJgQ5NuxjpBKTRP3pQhwkrkxqQjeoKJ+fO7bCpmIZaogI4eZGDMEGOw==", + "version": "5.0.1", + "resolved": "https://registry.npmjs.org/parse-json/-/parse-json-5.0.1.tgz", + "integrity": "sha512-ztoZ4/DYeXQq4E21v169sC8qWINGpcosGv9XhTDvg9/hWvx/zrFkc9BiWxR58OJLHGk28j5BL0SDLeV2WmFZlQ==", "dev": true, "requires": { "@babel/code-frame": "^7.0.0", @@ -4829,9 +4829,9 @@ "dev": true }, "regenerator-runtime": { - "version": "0.13.5", - "resolved": "https://registry.npmjs.org/regenerator-runtime/-/regenerator-runtime-0.13.5.tgz", - "integrity": "sha512-ZS5w8CpKFinUzOwW3c83oPeVXoNsrLsaCoLtJvAClH135j/R77RuymhiSErhm2lKcwSCIpmvIWSbDkIfAqKQlA==", + "version": "0.13.7", + "resolved": "https://registry.npmjs.org/regenerator-runtime/-/regenerator-runtime-0.13.7.tgz", + "integrity": "sha512-a54FxoJDIr27pgf7IgeQGxmqUNYrcV338lf/6gH456HZ/PhX+5BcwHXG9ajESmwe6WRO0tAzRUrRmNONWgkrew==", "dev": true }, "resolve": { @@ -4983,9 +4983,9 @@ "dev": true }, "regenerator-runtime": { - "version": "0.13.5", - "resolved": "https://registry.npmjs.org/regenerator-runtime/-/regenerator-runtime-0.13.5.tgz", - "integrity": "sha512-ZS5w8CpKFinUzOwW3c83oPeVXoNsrLsaCoLtJvAClH135j/R77RuymhiSErhm2lKcwSCIpmvIWSbDkIfAqKQlA==", + "version": "0.13.7", + "resolved": "https://registry.npmjs.org/regenerator-runtime/-/regenerator-runtime-0.13.7.tgz", + "integrity": "sha512-a54FxoJDIr27pgf7IgeQGxmqUNYrcV338lf/6gH456HZ/PhX+5BcwHXG9ajESmwe6WRO0tAzRUrRmNONWgkrew==", "dev": true }, "supports-color": { @@ -5517,9 +5517,9 @@ "dev": true }, "regenerator-runtime": { - "version": "0.13.5", - "resolved": "https://registry.npmjs.org/regenerator-runtime/-/regenerator-runtime-0.13.5.tgz", - "integrity": "sha512-ZS5w8CpKFinUzOwW3c83oPeVXoNsrLsaCoLtJvAClH135j/R77RuymhiSErhm2lKcwSCIpmvIWSbDkIfAqKQlA==", + "version": "0.13.7", + "resolved": "https://registry.npmjs.org/regenerator-runtime/-/regenerator-runtime-0.13.7.tgz", + "integrity": "sha512-a54FxoJDIr27pgf7IgeQGxmqUNYrcV338lf/6gH456HZ/PhX+5BcwHXG9ajESmwe6WRO0tAzRUrRmNONWgkrew==", "dev": true }, "resolve-from": { @@ -5872,9 +5872,9 @@ "dev": true }, "@types/webpack-sources": { - "version": "1.4.0", - "resolved": "https://registry.npmjs.org/@types/webpack-sources/-/webpack-sources-1.4.0.tgz", - "integrity": "sha512-c88dKrpSle9BtTqR6ifdaxu1Lvjsl3C5OsfvuUbUwdXymshv1TkufUAXBajCCUM/f/TmnkZC/Esb03MinzSiXQ==", + "version": "1.4.2", + "resolved": "https://registry.npmjs.org/@types/webpack-sources/-/webpack-sources-1.4.2.tgz", + "integrity": "sha512-77T++JyKow4BQB/m9O96n9d/UUHWLQHlcqXb9Vsf4F1+wKNrrlWNFPDLKNT92RJnCSL6CieTc+NDXtCVZswdTw==", "dev": true, "requires": { "@types/node": "*", @@ -11621,6 +11621,12 @@ "integrity": "sha512-ZIzRpLJrOj7jjP2miAtgqIfmzbxa4ZOr5jJc601zklsfEx9oTzmmj2nVpIPRpNlRTIh8lc1kyViIY7BWSGNmKw==", "dev": true }, + "detect-node-es": { + "version": "1.0.0", + "resolved": "https://registry.npmjs.org/detect-node-es/-/detect-node-es-1.0.0.tgz", + "integrity": "sha512-S4AHriUkTX9FoFvL4G8hXDcx6t3gp2HpfCza3Q0v6S78gul2hKWifLQbeW+ZF89+hSm2ZIc/uF3J97ZgytgTRg==", + "dev": true + }, "detect-port": { "version": "1.3.0", "resolved": "https://registry.npmjs.org/detect-port/-/detect-port-1.3.0.tgz", @@ -11966,9 +11972,9 @@ } }, "elliptic": { - "version": "6.4.1", - "resolved": "https://registry.npmjs.org/elliptic/-/elliptic-6.4.1.tgz", - "integrity": "sha512-BsXLz5sqX8OHcsh7CqBMztyXARmGQ3LWPtGjJi6DiJHq5C/qvi9P3OqgswKSDftbu8+IoI/QDTAm2fFnQ9SZSQ==", + "version": "6.5.3", + "resolved": "https://registry.npmjs.org/elliptic/-/elliptic-6.5.3.tgz", + "integrity": "sha512-IMqzv5wNQf+E6aHeIqATs0tOLeOTwj1QKbRcS3jBbYkl5oLAserA8yJTT7/VyHUYG91PRmPyeQDObKLPpeS4dw==", "dev": true, "requires": { "bn.js": "^4.4.0", @@ -16697,9 +16703,9 @@ "dev": true }, "is-docker": { - "version": "2.0.0", - "resolved": "https://registry.npmjs.org/is-docker/-/is-docker-2.0.0.tgz", - "integrity": "sha512-pJEdRugimx4fBMra5z2/5iRdZ63OhYV0vr0Dwm5+xtW4D1FvRkB8hamMIhnWfyJeDdyr/aa7BDyNbtG38VxgoQ==", + "version": "2.1.0", + "resolved": "https://registry.npmjs.org/is-docker/-/is-docker-2.1.0.tgz", + "integrity": "sha512-mB2WygGsSeoXtLKpSYzP6sa0Z9DyU9ZyKlnvuZWxCociaI0qsF8u12sR72DFTX236g1u6oWSWYFuUk09nGQEjg==", "dev": true }, "is-dom": { @@ -18163,18 +18169,18 @@ }, "dependencies": { "@babel/runtime": { - "version": "7.10.5", - "resolved": "https://registry.npmjs.org/@babel/runtime/-/runtime-7.10.5.tgz", - "integrity": "sha512-otddXKhdNn7d0ptoFRHtMLa8LqDxLYwTjB4nYgM1yy5N6gU/MUf8zqyyLltCH3yAVitBzmwK4us+DD0l/MauAg==", + "version": "7.11.0", + "resolved": "https://registry.npmjs.org/@babel/runtime/-/runtime-7.11.0.tgz", + "integrity": "sha512-qArkXsjJq7H+T86WrIFV0Fnu/tNOkZ4cgXmjkzAu3b/58D5mFIO8JH/y77t7C9q0OdDRdh9s7Ue5GasYssxtXw==", "dev": true, "requires": { "regenerator-runtime": "^0.13.4" } }, "regenerator-runtime": { - "version": "0.13.5", - "resolved": "https://registry.npmjs.org/regenerator-runtime/-/regenerator-runtime-0.13.5.tgz", - "integrity": "sha512-ZS5w8CpKFinUzOwW3c83oPeVXoNsrLsaCoLtJvAClH135j/R77RuymhiSErhm2lKcwSCIpmvIWSbDkIfAqKQlA==", + "version": "0.13.7", + "resolved": "https://registry.npmjs.org/regenerator-runtime/-/regenerator-runtime-0.13.7.tgz", + "integrity": "sha512-a54FxoJDIr27pgf7IgeQGxmqUNYrcV338lf/6gH456HZ/PhX+5BcwHXG9ajESmwe6WRO0tAzRUrRmNONWgkrew==", "dev": true } } @@ -26075,12 +26081,12 @@ "dev": true }, "use-sidecar": { - "version": "1.0.2", - "resolved": "https://registry.npmjs.org/use-sidecar/-/use-sidecar-1.0.2.tgz", - "integrity": "sha512-287RZny6m5KNMTb/Kq9gmjafi7lQL0YHO1lYolU6+tY1h9+Z3uCtkJJ3OSOq3INwYf2hBryCcDh4520AhJibMA==", + "version": "1.0.3", + "resolved": "https://registry.npmjs.org/use-sidecar/-/use-sidecar-1.0.3.tgz", + "integrity": "sha512-ygJwGUBeQfWgDls7uTrlEDzJUUR67L8Rm14v/KfFtYCdHhtjHZx1Krb3DIQl3/Q5dJGfXLEQ02RY8BdNBv87SQ==", "dev": true, "requires": { - "detect-node": "^2.0.4", + "detect-node-es": "^1.0.0", "tslib": "^1.9.3" } }, From 9d0a31d10bf1b3cd4b87add8e8851da7cc009f23 Mon Sep 17 00:00:00 2001 From: Mehmet Volkan D Date: Tue, 11 Aug 2020 11:22:40 +0200 Subject: [PATCH 2/5] [F] Redirect link support added to HDGallery component (#490) * :sparkles: redirect link support added to HDGallery component * :white_check_mark: test snapshots updated * :recycle: refactor and media component attr remove * :white_check_mark: update tests * :recycle: refactor and update tests --- src/components/gallery/HdGallery.vue | 15 ++++++++++----- src/components/gallery/HdGalleryCarousel.vue | 2 +- src/components/gallery/HdGalleryMedia.vue | 2 ++ .../{HdGallery.spec.js => HDGallery.spec.js} | 8 ++++---- ...ery.spec.js.snap => HDGallery.spec.js.snap} | 18 ++++++++++-------- 5 files changed, 27 insertions(+), 18 deletions(-) rename tests/unit/components/gallery/{HdGallery.spec.js => HDGallery.spec.js} (83%) rename tests/unit/components/gallery/__snapshots__/{HdGallery.spec.js.snap => HDGallery.spec.js.snap} (84%) diff --git a/src/components/gallery/HdGallery.vue b/src/components/gallery/HdGallery.vue index 8d23469aa..6ca3fed3f 100644 --- a/src/components/gallery/HdGallery.vue +++ b/src/components/gallery/HdGallery.vue @@ -8,16 +8,20 @@
{{ currentItemCaption || '​' }}
- +
+ +
-
@@ -312,6 +311,7 @@ export default { display: flex; align-items: center; justify-content: center; + z-index: 1; } } } diff --git a/src/components/gallery/HdGalleryMedia.vue b/src/components/gallery/HdGalleryMedia.vue index 64d48e97b..1417d4a4f 100644 --- a/src/components/gallery/HdGalleryMedia.vue +++ b/src/components/gallery/HdGalleryMedia.vue @@ -86,6 +86,7 @@ export default { align-items: center; justify-content: center; background-color: $secondary-bg; + cursor: pointer; &__thumbnail, &__picture { @@ -94,6 +95,7 @@ export default { right: 0; bottom: 0; left: 0; + z-index: 1; } &__picture { diff --git a/tests/unit/components/gallery/HdGallery.spec.js b/tests/unit/components/gallery/HDGallery.spec.js similarity index 83% rename from tests/unit/components/gallery/HdGallery.spec.js rename to tests/unit/components/gallery/HDGallery.spec.js index aa183e9c2..795229f81 100644 --- a/tests/unit/components/gallery/HdGallery.spec.js +++ b/tests/unit/components/gallery/HDGallery.spec.js @@ -2,7 +2,7 @@ import { wrapperFactoryBuilder } from 'tests/unit/helpers'; import HdGallery from '@/components/gallery/HdGallery.vue'; import ITEMS from '@/stories/mocks/GALLERY_ITEMS'; -const FIGURE_SELECTOR = '.gallery__figure'; +const IMAGE_SELECTOR = '.gallery__image'; const wrapperBuilder = wrapperFactoryBuilder(HdGallery, { props: { @@ -20,14 +20,14 @@ describe('HdGallery', () => { it('switchs elements and emits the proper events clicks', () => { const wrapper = wrapperBuilder(); const testIndex = 3; - const figure = wrapper.find(FIGURE_SELECTOR); + const image = wrapper.find(IMAGE_SELECTOR); - figure.trigger('click'); + image.trigger('click'); expect(wrapper.emitted('currentItemClick')[0][0]).toBe(0); wrapper.setData({ currentItemIndex: testIndex }); - figure.trigger('click'); + image.trigger('click'); expect(wrapper.emitted('currentItemClick')[1][0]).toBe(testIndex); }); }); diff --git a/tests/unit/components/gallery/__snapshots__/HdGallery.spec.js.snap b/tests/unit/components/gallery/__snapshots__/HDGallery.spec.js.snap similarity index 84% rename from tests/unit/components/gallery/__snapshots__/HdGallery.spec.js.snap rename to tests/unit/components/gallery/__snapshots__/HDGallery.spec.js.snap index 693facadb..66473dd8b 100644 --- a/tests/unit/components/gallery/__snapshots__/HdGallery.spec.js.snap +++ b/tests/unit/components/gallery/__snapshots__/HDGallery.spec.js.snap @@ -5,14 +5,16 @@ exports[`HdGallery renders component 1`] = `
Image 1
-
-
-
- - - - Image 1 -
+
+
+
+
+ + + + Image 1 +
+