Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making a Dashboard Icons website #375

Open
walkxcode opened this issue Apr 18, 2023 · 12 comments
Open

Making a Dashboard Icons website #375

walkxcode opened this issue Apr 18, 2023 · 12 comments

Comments

@walkxcode
Copy link
Collaborator

I am looking into building a nice looking website for the Dashboard Icons project.

Here are some feature's I am wanting to add:

  • Fuzzy search
  • PNG/SVG filtering
  • If both an SVG and PNG is present, show only the PNG version but show both on click
  • Lazy loading

If anyone would want to help me with this, please comment on this issue and I will assign you. If you have any suggestions, please also make a comment!

@itsprakashp
Copy link
Contributor

I think website can be made similar to the aegis-icons.
https://aegis-icons.github.io/, https://github.com/aegis-icons/aegis-icons

@walkxcode
Copy link
Collaborator Author

I think website can be made similar to the aegis-icons. aegis-icons.github.io, aegis-icons/aegis-icons

Thanks for the links! I'll see if I can find some inspiration.

@walkxcode walkxcode unpinned this issue Jun 7, 2023
@pradt
Copy link

pradt commented Jul 8, 2023

Hi, I've generated an example if this is what you are looking for (it'll need better styling) :

https://jsfiddle.net/prad/jk3tc2fs/3/

I've used the following to convert the html to have a text label and be within a list tag : https://jsfiddle.net/prad/cne0dk6z/9/

@walkxcode
Copy link
Collaborator Author

I think this is a really great start, but the fuzzy search will have to be improved loads more. For example, currently when searching "pihole", "pi-hole" will not show up. I am going on vacation in a couple of days but I will take a better look at your example when I'm back :)

@Mega-Volti
Copy link
Contributor

Why prefer the png version, if both svg and png are available? As vector format, the svg version offers better scalability so it should be the default / preferred one, right?

@pradt
Copy link

pradt commented Jul 19, 2023

I think this is a really great start, but the fuzzy search will have to be improved loads more. For example, currently when searching "pihole", "pi-hole" will not show up. I am going on vacation in a couple of days but I will take a better look at your example when I'm back :)

Ok no worries, enjoy your holidays.

Based on your feedback, writing a custom fuzzy logic function is probably going to take some time. Instead I've looked at two libraries (fuse.js and fuzzysort) and I was able to get better success from using the fuzzysort library : https://github.com/farzher/fuzzysort

I've created a working example, but I've had to convert the content to an array. But for testing purposes the update at https://jsfiddle.net/prad/jk3tc2fs/52/ (the initial display of all the icons is not shown at this stage, only after it passes the array of the icons to the fuzzy search it displays the result.

@walkxcode
Copy link
Collaborator Author

This is an absolutely great start! I think it still needs some optimizations, but this is superb.

@raythunder
Copy link

I have created a simple search page. It can be temporarily used by those who need it.
https://raythunder.github.io/dashboard-icons-search/

@walkxcode
Copy link
Collaborator Author

This is really nice! I'm going to take a further look at it once I find some time, I think after some improvements we could really use this.

@andrzej-zuralovic
Copy link

The icon searcher should always be up to date as it requests PNG and SVG content from GitHub.
https://andrzej-zuralovic.github.io/dashboard-icons-searcher/

@walkxcode
Copy link
Collaborator Author

Hi @andrzej-zuralovic, this looks fantastic! I’d love to integrate it into the repository if you’re okay with that.

I did notice a couple of bugs:

  1. Images wider than 512px aren’t scaling properly.
  2. Icons with longer names display oddly on hover.

@andrzej-zuralovic
Copy link

Hi @walkxcode , apologies for the delayed response. Yes, you can integrate it if you wish. I have also addressed the bugs you mentioned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants