LumenAI Views in Sidebar #610
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahuang11
commented
Jul 18, 2024
|
Appreciate the initiative on this, definitely looks better than what I had originally thought it would look like. That said I think we need to carefully think about UI/UX in general and work through some proposals. Separately is performance really still such a major issue? Seemed a lot better last I tried but I guess if chat is long enough it will always be an issue. |
I think if we can implement a right-sidebar, that'd be great. Another thought is pushing the view to a modal if we don't want to force user to use a template. One unaddressed issue with the current PR is exporting it is broken at the moment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #606
artifacts.mp4
This makes expensive views like plots and tables, pop up one at a time, on the sidebar instead of showing up in the chat feed, to prevent it from becoming laggy.
Logically, these views would make more sense to pop up on the right side, but templates only support sidebar on the left. Perhaps in the future, there can be a right_sidebar.