-
-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setting color
parameter to a hvplot.paths datashaded plot does not have any effect
#1443
Comments
Thanks. I also noticed that trying it using holoviews code however, emits a warning. Maybe the same warning could be implemented in hvPlot? import datashader as ds
import holoviews as hv
import pandas as pd
from holoviews.operation.datashader import datashade
hv.extension('bokeh')
df = pd.DataFrame({"x": [0, 1, None, 2, 3], "y": [0, 1, None, 2, 3],
"ascending": [True, True, None, False, False],})
plot = hv.Path(df, ["x", "y"], ["ascending"])
datashade(plot, aggregator=ds.by("ascending"), color=["black", "green"]) I'm open to adding that if it makes sense. |
This is confusing ngl. |
Unfortunately that's the case for a lot of features in hvPlot!
I didn't even have that kind of mapping in mind! So I don't have yet an opinion on the best course of action. I'd find great if we could work on referencing/documenting:
Once something like this is done, it will be way easier to make a decision, add some warning/error on inputs parsing, and maybe decide to deprecate stuff (hvPlot 1.0?). If done right we should also be able to use the info gathered to improve the documentation extensively on this front. This is work I could help you get started with @Azaya89. |
Sure, I'm open to getting started on this! |
ALL software version info
Software Version Info
Description of expected behavior and the observed behavior
Expected behavior
I expect the lines to be colored with the provided colors.
Observed behavior
The default colors are still used, ignoring the provided colors
Complete, minimal, self-contained example code that reproduces the issue
Stack traceback and/or browser JavaScript console output
None.
Screenshots or screencasts of the bug in action
The text was updated successfully, but these errors were encountered: