allow patch files in /usr/share/holo/files #5
Labels
Comments
LukeShu
added a commit
to LukeShu/holo
that referenced
this issue
Jan 23, 2018
…should I was working on implementing patch files (holocm#5), when I noticed the base = current line, which should obviously be base = tmp But if you fix the bug without writing a test, is it really fixed? So then I went about trying to figure out how to trigger misbehavior based on that mistake. In doing so, I found a second bug, when my test very clearly should have required `--force`, but it didn't. The fixes to both bugs are required to make the added test pass.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently, configuration can only be modified (as opposed to: replaced) by using holoscripts. Patch files could be more natural to some. Patch files are a bit different from the existing source files since they can work on multiple target files.
This might very well be a separate (non-core)
patchesplugin instead instead of an addition to thefilesplugin.(Migrated from holocm/holo-attic#1.)
The text was updated successfully, but these errors were encountered: