Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] new chpp file versions #1927

Closed
wsbrenk opened this issue Oct 3, 2023 · 5 comments
Closed

[FEATURE] new chpp file versions #1927

wsbrenk opened this issue Oct 3, 2023 · 5 comments
Assignees
Labels
status: needs test might be fixed, needs test before closing
Milestone

Comments

@wsbrenk
Copy link
Collaborator

wsbrenk commented Oct 3, 2023

Changelog
2023-09-07
players - 2.6
Note: Removed non-player trainers (now added it to the staff list) and replaced TrainerSkill with TrainerSkillLevel, for player trainers only.
Added Output: TrainerSkillLevel
Removed Output: TrainerSkill
playerdetails - 3.0
Note: Removed non-player trainers (now added it to the staff list) and replaced TrainerSkill with TrainerSkillLevel, for player trainers only.
Added Output: TrainerSkillLevel
Removed Output: TrainerSkill
staffavatars - 1.1
Note: Added trainer avatar
Added Output: Trainer
Added Output: TrainerId
Added Output: Avatar
Added Output: BackgroundImage
Added Output: Layer
Added Output: Image
stafflist - 1.2
Note: Added all trainer info
Added Output: Trainer
Added Output: TrainerId
Added Output: Name
Added Output: Age
Added Output: AgeDays
Added Output: ContractDate
Added Output: Cost
Added Output: CountryID
Added Output: TrainerType
Added Output: Leadership
Added Output: TrainerSkillLevel
Added Output: TrainerStatus

@wsbrenk wsbrenk added this to the 8.0 milestone Oct 3, 2023
@wsbrenk wsbrenk self-assigned this Oct 21, 2023
wsbrenk added a commit to wsbrenk/HO that referenced this issue Oct 21, 2023
@wsbrenk wsbrenk mentioned this issue Oct 21, 2023
2 tasks
wsbrenk added a commit that referenced this issue Oct 21, 2023
* #1927 new chpp file versions

* adjust rating string format
@wsbrenk wsbrenk closed this as completed Oct 21, 2023
@pencil
Copy link

pencil commented Oct 23, 2023

This seems to break download of trainer info for my team (trainer is externally recruited non-player):

image

java.lang.RuntimeException: CHPP Error - 56 -  (56) Additional Info: null
	at core.net.MyConnector.getCHPPWebFile(MyConnector.java:630)
	at core.net.MyConnector.downloadPlayerDetails(MyConnector.java:422)
	at core.file.xml.ConvertXml2Hrf.createHrf(ConvertXml2Hrf.java:139)
	at core.net.OnlineWorker.getHrf(OnlineWorker.java:71)
	at core.net.DownloadDialog.startDownload(DownloadDialog.java:305)
	at core.net.DownloadDialog.actionPerformed(DownloadDialog.java:87)
...

@wsbrenk wsbrenk reopened this Oct 24, 2023
@wsbrenk
Copy link
Collaborator Author

wsbrenk commented Oct 24, 2023

@pencil: bad - i can not debug this with my teams - could you provide your database backup.

@pencil
Copy link

pencil commented Oct 25, 2023

I think it has to do with my trainer being externally recruited (i.e. he was never a player). The API call in the screenshot does not seem to work in that case. I'll come back and add a database snapshot soon™ but I don't know how useful it will be without you having access to an affected account.

wsbrenk added a commit to wsbrenk/HO that referenced this issue Oct 26, 2023
@wsbrenk wsbrenk mentioned this issue Oct 26, 2023
2 tasks
wsbrenk added a commit that referenced this issue Oct 26, 2023
* #1927 fix trainer download
@wsbrenk
Copy link
Collaborator Author

wsbrenk commented Oct 26, 2023

@pencil would be great if you could test again with latest dev version. if it is still not working your database backup would help. With that i can try to debug your downloads. After my test you can reset your HO oauth setting to disable downloads by me.

tychobrailleur pushed a commit that referenced this issue Oct 27, 2023
* #1927 fix trainer download
@wsbrenk wsbrenk added the status: needs test might be fixed, needs test before closing label Nov 20, 2023
@pencil
Copy link

pencil commented Dec 1, 2023

Sorry for the delay here! I just tested with 8.0.550.0 and it seems to work now. Thank you! <3

@wsbrenk wsbrenk closed this as completed Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: needs test might be fixed, needs test before closing
Projects
None yet
Development

No branches or pull requests

2 participants