feat: feedback link #148
Merged
feat: feedback link #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
crfmc
commented
Nov 19, 2024
•
crfmc
commented
- Add feedback button to allow users to email
- Style buttons on navigation bar/vis-overview-panel navigation bar + interactions
- Restructure CSS
- Improve tab navigation for accessibility
-style: reorganize buttons -feat: new mail icon -feat: set variable to hold email address
-style: update navigation bar -feat: add menu icon -chore: add types
sehilyi
reviewed
Dec 10, 2024
src/App.css
Outdated
| @@ -40,9 +40,319 @@ a:hover { | |||
| text-decoration: 3px underline #5bb6ea; | |||
| } | |||
|
|
|||
| /* NavigationBar styles */ | |||
| .navigation-container { | |||
There was a problem hiding this comment.
Since we created a separate file for the navigation bar (src/ui/NavigationBar.tsx), should we make a separate CSS file as well (e.g., ui/NavigationBar.css)?
sehilyi
reviewed
Dec 10, 2024
src/App.tsx
Outdated
Comment on lines
763
to
776
| <NavigationBar | ||
| demo={demo} | ||
| setShowAbout={setShowAbout} | ||
| showSmallMultiples={showSmallMultiples} | ||
| setShowSamples={setShowSamples} | ||
| gosRef={gosRef} | ||
| currentSpec={currentSpec} | ||
| getHtmlTemplate={getHtmlTemplate} | ||
| demoIndex={demoIndex} | ||
| externalDemoUrl={externalDemoUrl} | ||
| externalUrl={externalUrl} | ||
| isChrome={isChrome} | ||
| FEEDBACK_EMAIL_ADDRESS={FEEDBACK_EMAIL_ADDRESS} | ||
| /> |
There was a problem hiding this comment.
Thank you for making this change! A lot cleaner than the previous inline implementation!
sehilyi
requested changes
Dec 10, 2024
-style: match navigation bar styles for vis-overview-panel -style: add hover state for overview panel links -chore: separate navigation bar styles -chore: create css folder
sehilyi
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.