You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I was expecting that adding "excludes-interfaces" would prevent lint errors if I was missing an @override marker, but not produce any errors if I did choose to correctly add an @override marker.
I've since realised that @override markers for implementing an interface are less useful, as you'll get a compile error if you typo a method name, etc. (as you won't now correctly implement the interface). A place where it is still useful is abstract classes, but that's a bit more of a corner-case.
But either way it might at least be worth clarifying in the docs so people know what to expect?
The text was updated successfully, but these errors were encountered:
You mean if you use the override keyword for an interface, and set "exclude-interfaces", then the plugin throws an error?
This is most likely a bug. I think it should instead ignore extraneous @ override keywords that override interfaces.
Yep, that's it exactly, thanks.
I won't have a chance for a week or so, but I'll definitely have a go after that (if you don't get there first). Be a good introduction before having a go at #11!
hmil
added
bug
Something isn't working
Needs code
The goal has been clearly stated. Feel free to contribute code to this issue.
In progress
Someone is working on this
and removed
Needs code
The goal has been clearly stated. Feel free to contribute code to this issue.
labels
Nov 26, 2018
I was expecting that adding "excludes-interfaces" would prevent lint errors if I was missing an
@override
marker, but not produce any errors if I did choose to correctly add an@override
marker.I've since realised that
@override
markers for implementing an interface are less useful, as you'll get a compile error if you typo a method name, etc. (as you won't now correctly implement the interface). A place where it is still useful is abstract classes, but that's a bit more of a corner-case.But either way it might at least be worth clarifying in the docs so people know what to expect?
The text was updated successfully, but these errors were encountered: