Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusing exclude-interfaces behaviour #12

Closed
TjlHope opened this issue Nov 15, 2018 · 4 comments · Fixed by #13
Closed

Confusing exclude-interfaces behaviour #12

TjlHope opened this issue Nov 15, 2018 · 4 comments · Fixed by #13
Labels
bug Something isn't working In progress Someone is working on this

Comments

@TjlHope
Copy link

TjlHope commented Nov 15, 2018

I was expecting that adding "excludes-interfaces" would prevent lint errors if I was missing an @override marker, but not produce any errors if I did choose to correctly add an @override marker.

I've since realised that @override markers for implementing an interface are less useful, as you'll get a compile error if you typo a method name, etc. (as you won't now correctly implement the interface). A place where it is still useful is abstract classes, but that's a bit more of a corner-case.

But either way it might at least be worth clarifying in the docs so people know what to expect?

@hmil
Copy link
Owner

hmil commented Nov 15, 2018

You mean if you use the override keyword for an interface, and set "exclude-interfaces", then the plugin throws an error?
This is most likely a bug. I think it should instead ignore extraneous @ override keywords that override interfaces.

@hmil
Copy link
Owner

hmil commented Nov 15, 2018

I created #13 . Let me know if that is what you were talking about. Feel free to work on a fix or otherwise I'll get to it when I have a minute.

@TjlHope
Copy link
Author

TjlHope commented Nov 15, 2018

Yep, that's it exactly, thanks.
I won't have a chance for a week or so, but I'll definitely have a go after that (if you don't get there first). Be a good introduction before having a go at #11!

@hmil hmil added bug Something isn't working Needs code The goal has been clearly stated. Feel free to contribute code to this issue. In progress Someone is working on this and removed Needs code The goal has been clearly stated. Feel free to contribute code to this issue. labels Nov 26, 2018
@hmil hmil closed this as completed in #13 Nov 26, 2018
@TjlHope
Copy link
Author

TjlHope commented Nov 29, 2018

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working In progress Someone is working on this
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants