Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support timezones #42

Open
joelmellon opened this issue Sep 3, 2020 · 2 comments
Open

Support timezones #42

joelmellon opened this issue Sep 3, 2020 · 2 comments

Comments

@joelmellon
Copy link

When outputting next run time, scheduler timezones aren't recognized. There are two techniques for setting timezone listed in the docs: https://laravel.com/docs/7.x/scheduling#timezones

I don't have much time to work on something like this, but I thought it might be a useful feature request.

@hmazter
Copy link
Owner

hmazter commented Sep 3, 2020

Timezones should be handled when calculating next run, see:

if ($this->timezone) {
$nextRun->setTimezone($this->timezone);
}

I don't use timezones myself so I have not tested it in a real application.
Could this be that it only handles one of the techniques for setting timezone?

@joelmellon
Copy link
Author

@hmazter You're right. It does see the timezone, but it appears as if the timezone has been applied backward. 00:00 Los Angeles is 07:00 UTC, but this says 17:00 which is 10:00 Los Angeles. It looks like it's subtracting 7 instead of adding it. Am I losing my mind?

Screen Shot 2020-09-02 at 11 56 57 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants