Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with secret value containing dash #18

Open
wenqiglantz opened this issue Oct 31, 2022 · 0 comments
Open

Issue with secret value containing dash #18

wenqiglantz opened this issue Oct 31, 2022 · 0 comments

Comments

@wenqiglantz
Copy link

wenqiglantz commented Oct 31, 2022

Hi, your action works great for secrets with value not containing dash (-), but I noticed that whenever a secret contains dash, your action doesn't persist the secret value when creating a new secret in GitHub. For example, the following step does create the new repo secret for S3_BUCKET_NAME, however, the value is blank (see verification step below).

     - name: Create GitHub Repository secret for frontend S3_BUCKET_NAME
        uses: hmanzur/[email protected]
        with:
          name: 'S3_BUCKET_NAME'
          value: 'abc-company-bucket'
          repository: ${{ github.repository }}
          token: ${{ secrets.GH_ACTIONS_SECRETS_PAT }}

When I tried to verify that newly created secret "abc-company-bucket" using this step below, it retrieved blank value. But when I modified the secret value from "abc-company-bucket" to "abccompanybucket" in the above step, this step retrieved that value successfully.

     - name: Verify secrets
        run: |
          echo ${{ secrets.S3_BUCKET_NAME }} | sed -e 's/\(.\)/\1 /g'

Please help find root cause and provide a fix. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant