You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Apr 4, 2022. It is now read-only.
... I assume wrong arguments can be given (like wrong attributeName) for the native impl. to throw an error.
In this case, the attributeChangedCallback will be called even the actual attribute set is not terminated...
Easy solution: invert the 2 lines, so the callback would not be fired if an error occured.
Less easy solution: Encapsulate the super call in a try/catch and call the callback only in case of success, and manage the error case...
The text was updated successfully, but these errors were encountered:
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Hello
This is a (very) small issue though, but reading this lines in file :
three-elements/packages/three-elements/src/BaseElement.ts
Lines 115 to 118 in a580feb
... I assume wrong arguments can be given (like wrong attributeName) for the native impl. to throw an error.
In this case, the attributeChangedCallback will be called even the actual attribute set is not terminated...
Easy solution: invert the 2 lines, so the callback would not be fired if an error occured.
Less easy solution: Encapsulate the super call in a try/catch and call the callback only in case of success, and manage the error case...
The text was updated successfully, but these errors were encountered: