New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Propose changes in Volvo's video block implementation #90

Closed

yugandhar02 opened this issue Aug 14, 2024 · 1 comment

Assignees

yugandhar02 commented Aug 14, 2024 •

edited

Loading

We recently added new video block which has following support

Renders poster image and delays video loading resulting into 100 LHS score even with video as hero banner
Have 3 different variants
- Modal
- Inline
- Hero
Auto pause videos once they go out of viewport
Customisation

The new video block can be located here
https://github.com/hlxsites/franklin-assets-selector/tree/main/blocks/video

yugandhar02 self-assigned this

Collaborator

sdmcraft commented Oct 13, 2024

@yugandhar02 anything pending here? If yes, please reopen.

sdmcraft closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment