Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement for Recommendation Endpoint #51

Merged
merged 1 commit into from
Jun 12, 2024
Merged

Improvement for Recommendation Endpoint #51

merged 1 commit into from
Jun 12, 2024

Conversation

hkulekci
Copy link
Owner

  • Recommendation Endpoint
  • min_should added for filters
  • GeoPolygon filter

@hkulekci hkulekci self-assigned this May 16, 2024
Copy link

codecov bot commented May 16, 2024

Codecov Report

Attention: Patch coverage is 97.59036% with 2 lines in your changes missing coverage. Please review.

Project coverage is 93.94%. Comparing base (70f0a5a) to head (62469cd).
Report is 2 commits behind head on main.

Files Patch % Lines
src/Endpoints/Collections/Points/Recommend.php 88.88% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main      #51      +/-   ##
============================================
+ Coverage     93.75%   93.94%   +0.19%     
- Complexity      377      401      +24     
============================================
  Files            73       76       +3     
  Lines          1185     1256      +71     
============================================
+ Hits           1111     1180      +69     
- Misses           74       76       +2     
Flag Coverage Δ
unittests 93.94% <97.59%> (+0.19%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

recommendation endpoint request improvement and filter min_should implementation. GeoPolygon request model implementation
improved recommendation endpoint
@hkulekci hkulekci merged commit 0ba31dc into main Jun 12, 2024
5 checks passed
@hkulekci hkulekci deleted the recommendation branch June 12, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant