Skip to content

incorrect accepting states #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hklarner opened this issue Apr 12, 2017 · 0 comments
Open

incorrect accepting states #14

hklarner opened this issue Apr 12, 2017 · 0 comments
Labels

Comments

@hklarner
Copy link
Owner

hklarner commented Apr 12, 2017

it seems that the initial states are computed incorrectly as being all states, when the CTL spec is true everywhere. minimal example:

primes = PyBoolNet.Repository.get_primes("raf")
update = "asynchronous"
init = "INIT !Raf"
spec = "CTLSPEC TRUE"
res, acc = PyBoolNet.ModelChecking.check_primes_with_acceptingstates(primes, update, init, spec)
print acc["INIT"], acc["INIT_SIZE"]

gives TRUE, 8 but !(Raf), 4 would be correct.

NuSMV is probably lazy (i.e. efficient) and trivial specs are caught without constructing BDDs.
suggested fix for next version: ModelChecking.check_primes_with_acceptingstates(..) will test whether the ctl spec is trivial (either TRUE or FALSE) and in that case set the keywords INIT and INIT_SIZE from the accepting states dictionary to None.

@hklarner hklarner added the bug label Apr 12, 2017
@hklarner hklarner changed the title the initial states of model checking with accepting states is incorrect if the spec is trivial incorrect accepting states Apr 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant