Skip to content
This repository has been archived by the owner on Dec 3, 2024. It is now read-only.

Support for International Charaters #95

Open
oldiron-ho opened this issue Jun 18, 2019 · 0 comments
Open

Support for International Charaters #95

oldiron-ho opened this issue Jun 18, 2019 · 0 comments

Comments

@oldiron-ho
Copy link

oldiron-ho commented Jun 18, 2019

When using Korean characters label, removing labels make some error.
It seems that international charaters in a label cause encoding problem.

git-labelmaker/bin/index.js

Lines 123 to 125 in dbe537f

if (confirmRemove.youSure) {
return gitLabel.remove(configGitLabel(repo, token), answers.removals);
}

Above code should be

          if (confirmRemove.youSure) {
             answers.removals.forEach(function(removal) {
                removal.name=encodeURIComponent(removal.name);
             })  
            return gitLabel.remove(configGitLabel(repo, token), answers.removals); 
         } 

I confirmed that the problem was resolved.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant