Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GAIL (PPO2 version) #592

Closed
rohitrango opened this issue Nov 30, 2019 · 3 comments
Closed

GAIL (PPO2 version) #592

rohitrango opened this issue Nov 30, 2019 · 3 comments
Labels
enhancement New feature or request

Comments

@rohitrango
Copy link

PPO2 is generally more stable and gives better results than TRPO. However, there is no version of GAIL with PPO. Could we have this feature in the repo? ( I was trying to dabble around with a PPO-GAIL anyway)

Thanks

@araffin araffin added the enhancement New feature or request label Dec 2, 2019
@araffin
Copy link
Collaborator

araffin commented Dec 2, 2019

Hello,
We are now focusing on the migration to tf2 (cf #366 ) so I would avoid adding new algorithms now.
We plan (cf #576 ) to drop GAIL support but you should still be able to use it thanks to this repo also maintained by @AdamGleave and depends on Stable Baselines.
Btw, @AdamGleave what algorithms are supported with GAIL? (maybe PPO is already supported)

@AdamGleave
Copy link
Collaborator

imitation uses PPO by default in its GAIL (and AIRL) implementation. But the RL algorithm is configurable by specifying a different model_class here. We've not tested with non-PPO, but other algorithms should work OK.

@araffin
Copy link
Collaborator

araffin commented Dec 2, 2019

Good to know, closing this issue then.

@araffin araffin closed this as completed Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants