Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question about the code in DLD #150

Open
csguoh opened this issue Mar 20, 2023 · 0 comments
Open

Question about the code in DLD #150

csguoh opened this issue Mar 20, 2023 · 0 comments

Comments

@csguoh
Copy link

csguoh commented Mar 20, 2023

Hi authors,

Thanks for your ownsome work of Dynamic Low-Resolution Distillation for Cost-Efficient End-to-End Text Spotting.

I have a question about the implementation about beam search. It seems that the function beam_decode receive the softmax results on teacher logits, which means it is a probability not the log probability. However, in this and this line, it seems that you have incorrectly treat the probability as log probability (although the name is logp...). I think multiply operator should be used instead of the add operator.

Best.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant