Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing functionalities for artefact store #22

Closed
jasonjunweilyu opened this issue Sep 16, 2024 · 1 comment
Closed

Missing functionalities for artefact store #22

jasonjunweilyu opened this issue Sep 16, 2024 · 1 comment

Comments

@jasonjunweilyu
Copy link
Collaborator

Currently, artefacts.py does not explicitly have methods for creating a new collection and filtering collections with filenames. So this additional method is needed for class ArtefactStore:

def filter_create_new(self, existing_collection: Optional [Union[str, ArtefactSet]], filenames: Optional[Union[Path, str, Iterable[Path], Iterable[str]]], new_collection: str):

This would enable the users to

(1) specify the files they want with filenames, filter an existing collection with the filenames and then return a new collection that is a subset of the existing collection.
(2) create an empty collection if the optional arguments are not set.

User cases of this would be like pass a collection to sourcegetter of a new psyclone step.

@hiker
Copy link
Owner

hiker commented Nov 25, 2024

Migrated to MetOffice#356

@hiker hiker closed this as completed Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants