Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design System: Radio Buttons #3938

Closed
zakhap opened this issue May 18, 2023 · 4 comments · Fixed by #4141
Closed

Design System: Radio Buttons #3938

zakhap opened this issue May 18, 2023 · 4 comments · Fixed by #4141
Assignees

Comments

@zakhap
Copy link
Collaborator

zakhap commented May 18, 2023

Description

A radio input allows users to select only one option from a number of choices. Radio is generally displayed in a radio group.

Checked: Yes, No
States: Default, Hover, Disabled

Colors:

  • If Checked = No and State = Default , color is Neutrals/400
  • If Checked = No and State = Hover , color is Primary Blue/600
  • If Checked = Yes and State = Default , color is Primary Blue/500
  • If Checked = Yes and State = Hover , color is Primary Blue/600
  • If State = Disabled, the color of the component will be Neutrals/200 and the background Neutrals/100

Resources:

Screen Shot 2023-05-18 at 10 57 02 PM

Acceptance Criteria

  • Component needs to be audited in Storybook with Story options for viewing each state.
@jnaviask jnaviask added the 2 Half day task label May 19, 2023
@jnaviask jnaviask assigned meeshlin and unassigned Miaplacidus Jun 2, 2023
@jnaviask jnaviask added refinement and removed 2 Half day task labels Jun 2, 2023
@jnaviask jnaviask assigned martins87 and unassigned meeshlin Jun 2, 2023
@martins87 martins87 added the 2 Half day task label Jun 5, 2023
@martins87
Copy link
Contributor

Cc @jnaviask @CowMuon @zakhap

This is a simple component but it is not on Mui Base at the moment (WIP on Unstyled components progress mui/base-ui#10)

Current Mui Base unstyled components:

image
image

Regarding this component (and more until #27170 is finished and ready to be used), what approach should we take?

Use Material UI and customize the components (heavier)? Build and customize simple HTML + CSS components from scratch (lighter) ?

@CowMuon
Copy link
Contributor

CowMuon commented Jun 15, 2023

What's the actual ticket status here? Comment history shows a question and then no updates for a solid 2 weeks @martins87 @zakhap

@martins87
Copy link
Contributor

What's the actual ticket status here? Comment history shows a question and then no updates for a solid 2 weeks @martins87 @zakhap

TLDR: PR mui/material-ui#4141 ready to be reviewed.

Regarding the ticket conversation, the doubt was solved in a call between me and Zak. He said to use all mui base components we can, until Unstyled components progress mui/base-ui#10 is done and we can implement all components from scratch from mui base.

@martins87
Copy link
Contributor

This RadioButton won't use mui base for now but instead simple html + css + phosphor icons.

@martins87 martins87 added 3 Full day task and removed 2 Half day task labels Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants