From 0bc6c125a65addb164f7492565d57fb5051cc3f9 Mon Sep 17 00:00:00 2001 From: Pedro Cattori Date: Mon, 22 Jan 2024 19:27:06 -0500 Subject: [PATCH] vite: fix "could not fast refresh" false alarm (#8580) --- .changeset/fast-dodos-yell.md | 9 +++++++++ packages/remix-dev/vite/plugin.ts | 3 ++- 2 files changed, 11 insertions(+), 1 deletion(-) create mode 100644 .changeset/fast-dodos-yell.md diff --git a/.changeset/fast-dodos-yell.md b/.changeset/fast-dodos-yell.md new file mode 100644 index 00000000000..84bc48a4049 --- /dev/null +++ b/.changeset/fast-dodos-yell.md @@ -0,0 +1,9 @@ +--- +"@remix-run/dev": patch +--- + +Vite: fix "could not fast refresh" false alarm + +HMR is already functioning correctly but was incorrectly logging that it "could not fast refresh" on internal client routes. +Now internal client routes correctly register Remix exports like `meta` for fast refresh, +which removes the false alarm. diff --git a/packages/remix-dev/vite/plugin.ts b/packages/remix-dev/vite/plugin.ts index 6da6b0f1023..372dd18f651 100644 --- a/packages/remix-dev/vite/plugin.ts +++ b/packages/remix-dev/vite/plugin.ts @@ -1468,7 +1468,8 @@ function addRefreshWrapper( code: string, id: string ): string { - let isRoute = getRoute(pluginConfig, id); + let isRoute = + id.endsWith(CLIENT_ROUTE_QUERY_STRING) || getRoute(pluginConfig, id); let acceptExports = isRoute ? [ "clientAction",