Skip to content

Stop using the HHVM test runner #863

Open
@fredemmott

Description

@fredemmott

Future work: blocked by having a good parallelism API. Likely going to be something convenient around xbox.

We have a mostly-compatible implementation of .expectf, .expectregex already for .typechecker.expectf: we no longer use run.php --typechecker: we can assume that 'No errors' tests have been verified by the repo-level hh_client call - so we can skip them for performance.

We use it for runtime tests still as we really really want the parallelism it offers, as we can't take a similar shortcut.

Benefits are:

  • including features (like .cli_args) in run.php that are not used by HHVM is painful
  • can potentially provide a better developer experience (e.g. test failure output) by using libraries - run.php must be standalone
  • can start listing each example as a separate test in hacktest output

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions