Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new release? #1450

Closed
21 tasks done
keewis opened this issue Jan 16, 2022 · 22 comments
Closed
21 tasks done

new release? #1450

keewis opened this issue Jan 16, 2022 · 22 comments

Comments

@keewis
Copy link
Contributor

keewis commented Jan 16, 2022

Since the last release in October we had quite a few bugfixes:

some new features:

and some docs updates (including the redesign):

and I'm sure I missed a few PRs (if so, feel free to edit the post)

We were originally planning to make a bugfix release, but I think we could just as well make a full release. What do you think, @hgrecco, @jules-ch?

@dalito
Copy link
Contributor

dalito commented Jan 16, 2022

What about merging #1409, too? It fixes a bug for offset units of higher dimension.

@jules-ch
Copy link
Collaborator

I'll check those PRs.

We can also change minimum Version support according to NEP29.

Python 3.8+
Numpy 1.19+

@hgrecco
Copy link
Owner

hgrecco commented Jan 16, 2022

Agreed on doing a release, maybe also a pint-pandas one just after that. Let's put a deadline. @jules-ch when do you think is reasonable?

@jules-ch
Copy link
Collaborator

I've reviewed @keewis PRs.
I think we can say end of this month.
I'l try to fix some bugs in the meantime

@jules-ch
Copy link
Collaborator

jules-ch commented Feb 2, 2022

@keewis can you make the appropriate changes after my review on #1419 #1421 #1422
So I can merge them.

@keewis
Copy link
Contributor Author

keewis commented Feb 2, 2022

sure, can you tell me what exactly I should change?

@keewis
Copy link
Contributor Author

keewis commented Feb 23, 2022

@jules-ch, what do we need to make this happen? I really hope it's not me that's blocking this...

@jules-ch
Copy link
Collaborator

Ok we should be good to go for a release, just waiting for #1454 to be merged.

@keewis I'm gonna wait for #1448, I haven't had time to review it, and I'm not sure delegating to registered formatter is making things simpler for the end user.
Can we delay this PR to the next release ?

@keewis
Copy link
Contributor Author

keewis commented Feb 23, 2022

it's not really urgent, but I was hoping to make use of this in a unit format that changes significantly once ~ is passed. I guess that means we can push it back for now?

What do you think about merging #1404?

@hgrecco
Copy link
Owner

hgrecco commented Feb 24, 2022

I was looking at the PRs which are still open (and not included here):

@hgrecco
Copy link
Owner

hgrecco commented Mar 24, 2022

Shall we release this weekend?

@keewis
Copy link
Contributor Author

keewis commented Mar 24, 2022

that would be great. What would be needed get there?

Edit: For the record, this is me volunteering to help

@jules-ch
Copy link
Collaborator

jules-ch commented Mar 28, 2022

@keewis @hgrecco If you guys can review #1476 & #1481. After that I think we are ready to do a release.
Next release, we can push the new version of the documentation.

@keewis
Copy link
Contributor Author

keewis commented Mar 28, 2022

with both of those merged that only leaves us with the remaining PRs that add new units (#1404, and I guess #1484) and the PR removing the pint-pandas notebook (#1483).

I think #1483 is uncontroversial and can be merged immediately, while the new units need a decision (I do think we can merge those too – they're one-line changes – but I don't really know when new units are suitable for addition to the default_en.txt)

@hgrecco
Copy link
Owner

hgrecco commented Mar 28, 2022

I agree with merging all three

@jules-ch
Copy link
Collaborator

Agreed, I think we need to provide guidelines on units that can be added to the default registry.
That will provide us checks that have to be fullfilled in order to add those units.

I'll add an issue for this.

@jules-ch
Copy link
Collaborator

@hgrecco Does the activation of Github Discussions is also on the menu, that can reduce the noise on Issues.
Ideas & day to day maintenance can be moved there also.

@jules-ch
Copy link
Collaborator

@hgrecco just merged the 3 PRs mentionned by @keewis

@OrangeChannel
Copy link

Should the new units be documented in the changelog? They weren't on the individual PRs.

@jules-ch
Copy link
Collaborator

jules-ch commented Mar 30, 2022

Done in #1494

@jules-ch
Copy link
Collaborator

Ok this time I think we are ready for that release :)

@hgrecco
Copy link
Owner

hgrecco commented Apr 4, 2022

I have just release Pint 0.19 Thanks for all the awesome work. I will do a few tests and then tweet about it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants