Skip to content

Publish on ghcr.io? #200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
halostatue opened this issue Dec 16, 2024 · 7 comments
Closed

Publish on ghcr.io? #200

halostatue opened this issue Dec 16, 2024 · 7 comments

Comments

@halostatue
Copy link
Contributor

In #185, @ericmj said:

Unfortunately not, Docker Hub is the authority of what images are available.

Since this is open source for open source projects, the use of GitHub Packages (ghcr.io/…) would be a nice alternative to have to DockerHub. When I’ve done this (https://github.com/KineticCafe/docker-aws-cli-session-manager/pkgs/container/aws-cli-session-manager and a couple of others in the KineticCafe organization), I have published them under the same names, but I’m wondering if it might not be better to publish these under different package names because I don't necessarily know that the tags would be any nicer to manage.

Given that Docker is introducing some level of consumption-based pricing (see https://www.docker.com/pricing/faq/#:~:text=What%20does%20Docker%20Hub%20Consumption%20Pricing%20mean%3F), this would not be a bad thing to have as an alternative.

I believe that it should be possible to migrate images (I haven't yet tried to do so, mostly because I started pushing to both ghcr and DockerHub at the same time) as this post suggests. Note that (1) it talks about moving images (I believe that existing images should be copied, not moved) and (2) it uses the old docker.pkg.github.com registry, not ghcr.io.

@ericmj
Copy link
Member

ericmj commented Dec 17, 2024

The Docker FAQ seems to refer to private repository pulls. Are there any changes coming for public images?

@halostatue
Copy link
Contributor Author

I'm not entirely sure, TBH. I know that all pulls are rate limited by IP regardless of authentication, but at different levels. Given that the post announcing the changes was a "we've made everything better" post that buried a fairly substantial price increase, I don't think the pull rate limits are going to get better.

If everyone switched to ghcr instead of DockerHub (which isn't happening for a bunch of reasons involving base images at a minimum) then GitHub might have to respond similarly, but I'm personally getting a real "pray I do not alter it any further" vibe from this latest Docker change.

@halostatue
Copy link
Contributor Author

halostatue commented Dec 17, 2024

The pull rate limits apply across public and private images as before.

@ericmj
Copy link
Member

ericmj commented Dec 17, 2024

It's not really clear to me what the changes are or what the implications are (and it's of course an issue that Docker makes it so hard to understand). But until we know I would refrain from making any changes to Bob since supporting multiple registries would require extra maintenance. The way we build images unfortunately requires a lot of storage so we may also run into hidden GitHub limits.

@halostatue
Copy link
Contributor Author

Understood; the images that I’m storing are much smaller and more constrained, so I don't expect my OSS use of them to be problematic, but I appreciate the immutable nature of the hexpm image tags.

@ericmj
Copy link
Member

ericmj commented Dec 17, 2024

I will close the issue for now but if the docker changes turn out to be breaking we will of course reconsider. Thanks for raising the issue and for the proposal!

If other people are interested in GHCR images please drop a comment or thumbs down and we can reevaluate baed on that as well.

@ericmj ericmj closed this as completed Dec 17, 2024
@halostatue
Copy link
Contributor Author

If this changes, I would be happy to provide what assistance I can.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants