Skip to content

xcode-frameworks: remove workaround once Zig package manager can extract tarball #903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
emidoots opened this issue Jul 31, 2023 · 2 comments
Closed

xcode-frameworks: remove workaround once Zig package manager can extract tarball #903

emidoots opened this issue Jul 31, 2023 · 2 comments
Labels
package-manager
Milestone
Mach 0.3

Comments

@emidoots
Copy link
Member

emidoots commented Jul 31, 2023 •
edited
Loading

https://github.com/hexops/xcode-frameworks cannot be used directly via the Zig package manager, because it cannot download/extract the URL. It is likely because of ziglang/zig#16678 and so we may be able to fix it by squashing symlinks (which we need to do anyway for better windows cross-compilation support)

https://github.com/hexops/xcode-frameworks/archive/054d0f00f5244564fd86aaf9b31faa254450f249.tar.gz

The error is error: TarUnsupportedFileType

To workaround this we have a hack/package that clones the dependency for us: https://github.com/hexops/xcode-frameworks-pkg
@emidoots emidoots modified the milestones: Mach 0.3, Mach 0.2 Jul 31, 2023
emidoots pushed a commit to hexops-graveyard/xcode-frameworks-pkg that referenced this issue Aug 4, 2023
implement workaround for hexops/mach#903
1b01b42 
Thanks to @mitchellh for the inspiration and letting me borrow some
code!

Signed-off-by: Stephen Gutekanst <[email protected]>
@emidoots
Copy link
Member Author

emidoots commented Aug 4, 2023

Thanks to Mitchell Hashimoto we've got a workaround for this temporarily: https://github.com/hexops/xcode-frameworks-pkg

emidoots pushed a commit to hexops-graveyard/mach-gpu-dawn that referenced this issue Aug 4, 2023
use xcode-frameworks via package manager
ce6213f 
Works around hexops/mach#903

Signed-off-by: Stephen Gutekanst <[email protected]>
emidoots pushed a commit to hexops-graveyard/mach-gpu that referenced this issue Aug 4, 2023
remove all submodules (use package manager)
40c5546 
Helps hexops/mach#903

Signed-off-by: Stephen Gutekanst <[email protected]>
emidoots pushed a commit to hexops/mach-core that referenced this issue Aug 4, 2023
remove all submodules (use package manager)
0f09ae8 
Helps hexops/mach#903

Signed-off-by: Stephen Gutekanst <[email protected]>
emidoots pushed a commit that referenced this issue Aug 4, 2023
remove all submodules (use package manager)
fe1984c 
Helps #903

Signed-off-by: Stephen Gutekanst <[email protected]>
@emidoots emidoots changed the title all: Zig package manager cannot extract xcode-frameworks tarball, leading to a viral Git submodule in all our projects xcode-frameworks: remove workaround once Zig package manager can extract xcode-frameworks tarball Aug 4, 2023
@emidoots emidoots changed the title xcode-frameworks: remove workaround once Zig package manager can extract xcode-frameworks tarball xcode-frameworks: remove workaround once Zig package manager can extract tarball Aug 4, 2023
@emidoots emidoots modified the milestones: Mach 0.2, Mach 0.3 Aug 5, 2023
@emidoots
Copy link
Member Author

emidoots commented Oct 7, 2023

This can be fixed now

@emidoots emidoots mentioned this issue Oct 17, 2023
Closed
1 task
@emidoots emidoots mentioned this issue Oct 17, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
package-manager
Projects
None yet
Milestone
Mach 0.3
Development

No branches or pull requests
1 participant
@emidoots