Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maybe add winston and detailed logging of all incoming requests in dev? #78

Open
Shamash2014 opened this issue Mar 14, 2016 · 6 comments
Open

Maybe add winston and detailed logging of all incoming requests in dev? #78

Shamash2014 opened this issue Mar 14, 2016 · 6 comments

Comments

@Shamash2014
Copy link
Contributor

Pretty printed json with useful info from incoming requests in dev is good I think) But I can be overhead for such little MVP
@sashashakun
Copy link
Collaborator

Not bad idea. Any opinions, @gldmtr @Nitive @alexander37137 ?

@gldmtr
Copy link
Contributor

gldmtr commented Mar 15, 2016

I think that we doesn't need to log requests now

@sashashakun
Copy link
Collaborator

Anyway, will talk about it after #51 :)

@Nitive
Copy link
Contributor

Nitive commented Mar 16, 2016

We can customise morgan output.
Try replace morgan('dev') with morgan('combined').

@Nitive
Copy link
Contributor

Nitive commented Mar 16, 2016

We can choose output depends on NODE_ENV.

@sashashakun
Copy link
Collaborator

Is there big difference between morgan and winston? If no, let's just add some configuration to current logger. /cc @Shamash2014 @Nitive

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@gldmtr @sashashakun @Nitive @Shamash2014