Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update network subnet types #431

Merged
merged 1 commit into from
Aug 6, 2024
Merged

fix: update network subnet types #431

merged 1 commit into from
Aug 6, 2024

Conversation

jooola
Copy link
Member

@jooola jooola commented Jul 31, 2024

  • Update the properties documentation
  • Add deprecation warning for long deprecated TYPE_SERVER.

Copy link

codecov bot commented Jul 31, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.

Project coverage is 93.04%. Comparing base (a73050b) to head (9d93959).
Report is 26 commits behind head on main.

Files with missing lines Patch % Lines
hcloud/networks/domain.py 71.42% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #431      +/-   ##
==========================================
- Coverage   93.10%   93.04%   -0.07%     
==========================================
  Files          64       64              
  Lines        2960     2963       +3     
==========================================
+ Hits         2756     2757       +1     
- Misses        204      206       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jooola jooola marked this pull request as ready for review July 31, 2024 09:35
@jooola jooola requested a review from apricote August 5, 2024 13:45
- Update docs
- Add deprecation
@jooola jooola merged commit c32a615 into main Aug 6, 2024
10 checks passed
@jooola jooola deleted the network-subnet-types branch August 6, 2024 10:58
jooola pushed a commit that referenced this pull request Aug 6, 2024
🤖 I have created a release *beep* *boop*
---


##
[2.2.0](v2.1.1...v2.2.0)
(2024-08-06)


### Features

* retry requests when the api gateway errors
([#430](#430))
([f63ac8b](f63ac8b))
* retry requests when the api returns a conflict error
([#430](#430))
([f63ac8b](f63ac8b))
* retry requests when the network timed outs
([#430](#430))
([f63ac8b](f63ac8b))
* retry requests when the rate limit was reached
([#430](#430))
([f63ac8b](f63ac8b))


### Bug Fixes

* update network subnet types
([#431](#431))
([c32a615](c32a615))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants