fix: change annotation LBSvcRedirectHTTP to "https" #750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This would be a breaking change.
|
Thanks for the PR @a-mader, this is indeed a breaking change, so I will not merge it as is. I wrote a bit about the origin of the current annotation and the alternative I would like to see in #656 (comment). If you want you can adjust this PR to match my suggestion in the linked comment. |
|
Hi @apricote, what do you think about having both annotations available, but marking the old one for deprecation? e.g.
// MARKED FOR DEPRECATION (LBSvcRedirectHTTP create a redirect from HTTP to HTTPS. HTTPS only.)
LBSvcRedirectHTTP Name = "load-balancer.hetzner.cloud/http-redirect-http"
// LBSvcRedirectHTTP create a redirect from HTTP to HTTPS. HTTPS only. Bool either "true" or "false"
LBSvcRedirectHTTPS Name = "load-balancer.hetzner.cloud/http-redirect-https"and update the documentation to use the new annotation. Kind regards |
|
I would prefer to not mark |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I think this should be renamed from "http-to-http" to "http-to-https" and this would be a breaking change.
Closes #656
Kind regards