Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically label robot nodes #650

Open
mkuf opened this issue May 27, 2024 · 2 comments
Open

Automatically label robot nodes #650

mkuf opened this issue May 27, 2024 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed pinned

Comments

@mkuf
Copy link

mkuf commented May 27, 2024

TL;DR

Robot nodes should automatically be labelled with

instance.hetzner.cloud/is-root-server: true

Expected behavior

The csi driver is using the label to prevent the node component to start on robot nodes, see
https://github.com/hetznercloud/csi-driver/blob/071d0e36c2abffcd92cf3d92dfe75babd33879a2/chart/values.yaml#L532-L540 for reference.

This label is not set automatically by the ccm and requires additional user intervention when adding robot nodes to the cluster.

The ccm should add this label automatically as it already knows which nodes are from the robot type and which are from the hcloud type.

@mkuf mkuf added the enhancement New feature or request label May 27, 2024
@apricote
Copy link
Member

This is actually supported in Kubernetes v1.30+: kubernetes/kubernetes#123223

So we can implement this once we upgrade to that version.

@apricote
Copy link
Member

apricote commented Jul 8, 2024

We upgraded our dependency to Kubernetes v1.30. This can now be easily added in 2 lines:

return &cloudprovider.InstanceMetadata{

Happy to take any contributions :)

@apricote apricote added help wanted Extra attention is needed good first issue Good for newcomers pinned labels Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed pinned
Projects
None yet
Development

No branches or pull requests

2 participants