-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
💡 [FEATURE REQUEST] Improved Default Zoom for all Kepler Maps #1093
Comments
I need paul's input to help specific upon which point the 200km radius/rect is centred upon. I'm thinking to find the centre we could do something like chop off 25% outliers that are most distant from the others and use mean average position of the remaining 75% points? This will chop off holidays and short trips (which you identified as an issue) but i am not sure how well this will work for people who have data in two very disparate locations (e.g. people who have lived overseas like myself, data in both UK and Canada, don't want to end up centring on atlantic ocean centre) |
Paul has clarified the centre point should be:
Apparently this is different from average location, and can get around issues with someone who moved city. Will need to dig into code to understand how it works. |
I meant my comment for Gmaps. We didn't use Uber driver when doing the coaching session with client yesterday. The ticket is formulated at the top with a different scope than what I intended:
|
I think you are saying:
and
have i understood correctly? If so, please provide additional detail how I can identify what other tabs 1. applies to. |
In the current situation wait for a bug report? The ideal would be that we could quickly identify all the experience tabs relying on kepler, then those that display points. (That ideal should not be pursued on its own. Many parallel tactical steps go in this direction, such as optimizing Uber driver for digipower live.) Which makes me think: my Uber passenger is going to be subject to the same problem (I do airdrop around the world), and we should have my own data as a sample dataset and now I am tempted to put this in scope for the next digipower live (with home address removed). |
No, not waiting for anything now. I can action this. It's next up after #1092 Where you can help is to highlight places where you see issues with default zoom, as you notice them - just add them to this ticket (experience+tab+which dataset). Will be good to have multiple test scenarios. |
BTW presumably since this is now focused scope on google maps that makes it lower priority than the Uber-centric stuff within #1087 that is needed for Thursday? If so I will drop priority to medium |
Lowering priority as reasoned above, and removing from kepler/uber working set. |
This is also on hold pending resolution of #1104 |
Given #1104 has no way forward, we have to find a work around for developing this (such as use of a local/test CDN URL, or using the Kepler standalone project). |
Unassigned myself in case I don't get to this before going on leave and it needs advancing - but if it still here next week I will pick it up again. |
putting this down to work on other things. Other people could pick it up if needed. ask me if any questions. |
@pdehaye https://github.com/digipower-academy/private/issues/22 suggests this feature request should be reprioritised. could you clarify whether this feature req is higher priority than directus work and how far you want us to go (e.g. do we do it for all experiences, do we do a fixed area (e.g. Europe) as suggested in linked ticket, or do we do it per the data (as described in this ticket above). |
It's a higher priority for you to do this than Directus work. |
Thanks, and any comment on scope/spec please? |
I propose that the best sensible default for all maps might be this general algorithm:
I think this should give us a decent view for all datasets, whereever the points are in the world, with a view window just outside the extent of all available data. |
UPDATE: This is no longer correct so the rest of this comment can be disregarded. old (ignore)The zoom levels are a small integer (e.g. 9). These don't seem to be documented in KeplerGL docs but my working assumption is they are the same as Mapbox Zoom levels (since keplerGL uses Mapbox). On this basis the new strategy is:
It's not ideal, because sometimes we may want city or country or earth level. Will review this option with team. |
UPDATE: After further investigation of https://github.com/digipower-academy/private/issues/22, i can now say categorically that :
Therefore, there is nothing to do here and I will close this feature request. The only open question is what to do about default behaviour when there is no geodata. Options include: a) hide the map and only show the table - because there is nothing to show This can be handled as part of ticket https://github.com/digipower-academy/private/issues/22 BTW, if we ever do need an improved zoom, I checked in some code on default-zoom-enhancement branch that may be useful. But i think Kepler default behaviour is good enough and this branch can be ignored/archived/deleted. |
Paul pointed out that on maps (e.g. Uber, Google locations) the default view is scoped to show the whole world.
Instead, the map should zoom to something closer to the maximal extent of the points in the data.
It should take whichever is the smaller area of :
The text was updated successfully, but these errors were encountered: