You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
From #1469 (comment), it was brought up that I removed a logging call and didn't replace it. This logging functionality is not being used, so it's presence is causing confusion and it adds no value.
We should:
Remove all calls to log() in the codebase
Remove log function
Remove the internals that only log uses, such as log_internal
Do an audit to see if any other functionality to support logging is no longer used by any other codepaths, for example the value set here@id = Digest::SHA1.hexdigest("#{Time.now.to_f}-#{rand(1000000)}")[0..10] is being consumed by the logger. If it's not being used anywhere else we can get rid of it.
We need to take care to not break builds. We have a lot of integration tests, but they're not comprehensive. A one-in-a-million occurrence happens pretty frequently around here. Ruby does not give strong static guarantees.
The text was updated successfully, but these errors were encountered:
From #1469 (comment), it was brought up that I removed a logging call and didn't replace it. This logging functionality is not being used, so it's presence is causing confusion and it adds no value.
We should:
log()
in the codebaselog
functionlog
uses, such aslog_internal
@id = Digest::SHA1.hexdigest("#{Time.now.to_f}-#{rand(1000000)}")[0..10]
is being consumed by the logger. If it's not being used anywhere else we can get rid of it.We need to take care to not break builds. We have a lot of integration tests, but they're not comprehensive. A one-in-a-million occurrence happens pretty frequently around here. Ruby does not give strong static guarantees.
The text was updated successfully, but these errors were encountered: