Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow custom database.yml without activerecord #1325

Open
JacobEvelyn opened this issue Oct 24, 2022 · 2 comments
Open

Allow custom database.yml without activerecord #1325

JacobEvelyn opened this issue Oct 24, 2022 · 2 comments

Comments

@JacobEvelyn
Copy link

I previously opened #1278 for this issue and I'm not sure why it was closed. This buildpack overwrites our config/database.yml unless we have activerecord in our Gemfile, but we don't actually use activerecord (we use the sequel gem instead, which also uses config/database.yml). Is there a way this buildpack can allow us to remove activerecord from our Gemfile without overwriting our config/database.yml file?

Requiring a gem we don't need is annoying, slows down our bundle install times, and increases our surface area for security vulnerabilities.

@schneems
Copy link
Contributor

schneems commented Oct 6, 2023

Ahh. I didn't understand the request fully. I see and understand it. I'm not sure how to gate or guard this logic though. A simple solution would be to add an escape valve-like env var check like HEROKU_SKIP_DATABASE_YML_WRITE=1

Would something like that work for you?

@JacobEvelyn
Copy link
Author

That probably would work, but we've actually migrated off of Heroku so I personally am less invested in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants