Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port virtiofsd's filesystem-related security mechanisms #843

Open
4 tasks
n0toose opened this issue Dec 17, 2024 · 3 comments
Open
4 tasks

Port virtiofsd's filesystem-related security mechanisms #843

n0toose opened this issue Dec 17, 2024 · 3 comments

Comments

@n0toose
Copy link
Member

n0toose commented Dec 17, 2024

The following seems interesting:

If any source code-related files are copied, the license header will be preserved (plus, some additional author-related metadata as a courtesy to the original implementers). We should also "give credit" somewhere in the program; the software is licensed under BSD-3-Clause and Apache-2.0, which should be compatible with the MIT license.

@n0toose
Copy link
Member Author

n0toose commented Dec 17, 2024

@jounathaen although I can't guarantee that I'll be able to do everything in the end, are you, at least in principle, against any of the changes mentioned above?

@jounathaen
Copy link
Member

I definitely need more information on what you want to do. Maybe you can elaborate here a little or explain it to me in person.

@n0toose
Copy link
Member Author

n0toose commented Dec 17, 2024

That's a meeting for another day, but, in short, virtiofsd may be acting as a daemon for a communication protocol, but its "threat model" regarding processing foreign files using commands from an untrusted guest OS is like Uhyve's. What if a VM creates more files than what is possible on the host OS? What if we could combine Landlock and seccomp, the latter of which allows us to restrict system calls (which is still a bit paranoid, but good to have)?

That come be at the expense of other ideas I had - if time allows -, such as extending supported system calls. The question is "adapt it how?", so I will probably have to rush out Landlock first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants