Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API requests double // #76

Open
nfacha opened this issue Dec 31, 2021 · 1 comment · May be fixed by #77
Open

API requests double // #76

nfacha opened this issue Dec 31, 2021 · 1 comment · May be fixed by #77

Comments

@nfacha
Copy link

nfacha commented Dec 31, 2021 •
edited
Loading

This lib will append double slahes to the API endpoints, instead of https://site.com/api/v1/checks it generates them as https://site.com/api/v1//checks.

While this works with the public version it will not work out of the box if its a self-hosted instance

A pull-request will follow fixing this issue
@nfacha nfacha linked a pull request Dec 31, 2021 that will close this issue
Open
@jurgenhaas
Copy link

Just came across the same issue, but the situation seems slightly more differentiated. I was running the self-hosted version successfully inside docker and behind an Apache proxy. The clients using this SDK had no issues whatsoever.

Yesterday, I replaced Apache with Traefik as the reverse proxy, and suddenly this problem came up. My guess is that Apache proxy probably autocorrects double slashes in paths.

In any event, sending double slashes in the first place seems wrong and I can confirm that #77 solves the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Avoid double slahes on endpoints FreeMcServer/PHP-healthchecks.io
2 participants
@jurgenhaas @nfacha