Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify impressConsole to work without requiring configuration parameter #5

Closed
henrikingo opened this issue Jul 17, 2016 · 1 comment

Comments

@henrikingo
Copy link
Owner

Currently impressConsole requires a path to its cssFile to work. After adding the src/plugins/extras/ plugin we pass it thusly:

<script type="text/javascript" src="../../extras/impress-console/js/impressConsole.js"></script>
  <script type="text/javascript">
  // For impressConsole, we unfortunately must also set the path to a mandatory css file
  // which is relative to this html file.
  // See https://github.com/regebro/impress-console/issues/19
  var impressConsoleCss = '../../extras/impress-console/css/impressConsole.css';
</script>

TODO

  • Create a patch on impressConsole to have minimal CSS inline, so that it works sanely without providing an external CSS file.
  • Submit PR against impressConsole repo.
    • If they wouldn't accept it, maintain a fork.

For more context, see regebro/impress-console#19

@henrikingo henrikingo changed the title Modify impressConsole to work without requiring configuraion parameter Modify impressConsole to work without requiring configuration parameter Jul 17, 2016
@henrikingo
Copy link
Owner Author

This was done in c10c999

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant