Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typings for functions with no parameter are incorrect #30

Open
gndelia opened this issue Nov 21, 2024 · 0 comments
Open

Typings for functions with no parameter are incorrect #30

gndelia opened this issue Nov 21, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@gndelia
Copy link
Contributor

gndelia commented Nov 21, 2024

Functions such as getLastHeader don't have any parameter. However, the way the exposed function infers them requires in typescript to pass undefined as parameter, otherwise it won't work.

expected

const client = publicClient.extend(hemiPublicBitcoinKitActions())
client.getLastHeader() // Doesn't work in typescript; should not require any parameter, but it requires "undefined" passed to compile
client.getLastHeader(undefined) // works
@gndelia gndelia added the bug Something isn't working label Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant