Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dark mode #28

Open
gianpaj opened this issue Oct 24, 2020 · 8 comments
Open

Add Dark mode #28

gianpaj opened this issue Oct 24, 2020 · 8 comments
Labels

Comments

@gianpaj
Copy link
Collaborator

gianpaj commented Oct 24, 2020

No description provided.

@gianpaj gianpaj added enhancement New feature or request good first issue Good for newcomers labels Oct 24, 2020
@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the label feature_request to this issue, with a confidence of 0.98. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

@guyus15
Copy link

guyus15 commented Oct 25, 2020

Hi, can I work on this?

@gianpaj
Copy link
Collaborator Author

gianpaj commented Oct 26, 2020

Of course @guyus15 !

I think we need some toggle button.
for example:

resources:

This button has to:

  • not only toggle the CSS for the site but also change the map styles

@guyus15
Copy link

guyus15 commented Oct 27, 2020

Of course @guyus15 !

I think we need some toggle button.
for example:

resources:

This button has to:

  • not only toggle the CSS for the site but also change the map styles

So you would like the map to be a dark theme as well?

@gianpaj
Copy link
Collaborator Author

gianpaj commented Oct 27, 2020

@guyus15 yes, please

At the moment the Map Style used is: src/components/BlueEssence.js

https://snazzymaps.com/style/61/blue-essence

this is hardcoded in :
src/components/ReactiveGoogleMap.js

https://github.com/helpmap/helpmap.io/blob/master/src/components/ReactiveGoogleMap.js#L13

const BlueEssence = require('./BlueEssence');

But if this is a big task, happy to split this into 2

Regarding which Dark Map Style we could pick one of these:

I'll ask @krokubik (Designer) to chime in regarding this

@guyus15
Copy link

guyus15 commented Oct 27, 2020

@gianpaj Okay,

So far I've added a button to toggle the dark mode.
Forked repository: https://github.com/guyus15/helpmap.io

@gianpaj
Copy link
Collaborator Author

gianpaj commented Oct 27, 2020

Great! let me know when you want me to have a look

Alex said we use this map style https://snazzymaps.com/style/20053/multi-brand-network

@gianpaj
Copy link
Collaborator Author

gianpaj commented Oct 31, 2020

@guyus15 how's it going? I see from your last commit (guyus15@988edf1) you're already setting the CSS variables to change the colours. Nice!

When you think your branch is ready to be reviewed, please do create PR in here and I'll be happy to review it 👍

By the way, you can find me on Telegram with my same username to chat – if you'd like to chat privately and a bit faster

@gianpaj gianpaj linked a pull request Nov 16, 2020 that will close this issue
3 tasks
@gianpaj gianpaj reopened this May 30, 2021
@helpmap helpmap deleted a comment from github-actions bot May 30, 2021
@helpmap helpmap deleted a comment from github-actions bot May 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants