Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

naming convention for charts and variables #9636

Closed
azamin opened this issue Apr 21, 2021 · 5 comments
Closed

naming convention for charts and variables #9636

azamin opened this issue Apr 21, 2021 · 5 comments

Comments

@azamin
Copy link

azamin commented Apr 21, 2021

Hello, the naming convention says that helm chart name can contain dashes, but variable name not:

Chart names must be lower case letters and numbers. Words may be separated with dashes (-):
https://helm.sh/docs/chart_best_practices/conventions/

Variable names should begin with a lowercase letter, and words should be separated with camelcase:
https://helm.sh/docs/chart_best_practices/values/

If i have a subchart named subchart-name, will I violate the naming convention with these values.yaml in my umbrella chart:

subchart-name:
  name: nginx

Here is an example: confluentinc/cp-helm-charts

Thanks

@bacongobbler
Copy link
Member

bacongobbler commented Apr 21, 2021

That is correct. In those cases #2192 may help provide workarounds. It is still okay to use dashes in chart names, but as you point out there it is a little more difficult to work with inside a template.

What are you suggesting we change?

@azamin
Copy link
Author

azamin commented Apr 21, 2021

thank you @bacongobbler for the super quick response.
I have no suggestions ... it was just a question.

@azamin azamin closed this as completed Apr 21, 2021
@jackson-chris
Copy link

This is a design flaw that seems like we're stuck with but all users using sub charts will face this problem if they use the conventions you've laid out. The closing statement in #2192 says that documentation was updated, but I see nothing that warns users of this problem and users are forced to do an internet search on how to work around this problem. I think you should update the documentation correctly. Either by stating that all sub charts should be aliased to a name without hyphens or that if you don't use alias than the workaround using index is required. And that workaround should be clearly documented.

@joejulian
Copy link
Contributor

@jackson-chris documentation issues should be filed in https://github.com/helm/helm-www/issues

@jackson-chris
Copy link

Thanks, created: helm/helm-www#1445

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants