Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changelog in release description #44

Open
smlx opened this issue Oct 6, 2020 · 3 comments · May be fixed by helm/chart-releaser#439
Open

Changelog in release description #44

smlx opened this issue Oct 6, 2020 · 3 comments · May be fixed by helm/chart-releaser#439

Comments

@smlx
Copy link

smlx commented Oct 6, 2020

I think it would be useful for the PR that triggered the release to be optionally added to the release description as a changelog item.

@boxcee
Copy link
Contributor

boxcee commented Nov 10, 2020

Very useful indeed.

@stevehipwell
Copy link

I think this would need to be done within the action as there could be multiple charts being released. Something based on the code in mindsers/changelog-reader-action could read the chart changelog to provide body text.

@qrkourier
Copy link

Initially I, too, felt this functionality belongs in the Action. Then I noticed the Action is a thin shell wrapper for cr, and that changed my mind. It wouldn't make sense to extend the Action significantly or add dependencies on other Actions inside that composite Action.

Then I noticed that cr now has flag --generate-release-notes that enables the GitHub API's eponymous feature.

That is neat, but does not filter the changeset by chart-specific path or chart-specific release tag, so each chart release will presumably be plastered with release notes from other charts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants