From cebbed0eb223ab78db68fdc1f8c37818dea6f316 Mon Sep 17 00:00:00 2001 From: Marc Khouzam Date: Sun, 4 Aug 2019 21:46:00 -0400 Subject: [PATCH 1/4] Wrong variable prevents from finding correct tools Signed-off-by: Marc Khouzam Signed-off-by: Skylar Calvert --- scripts/acceptance.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/acceptance.sh b/scripts/acceptance.sh index 9dfa75a..f5d2f23 100755 --- a/scripts/acceptance.sh +++ b/scripts/acceptance.sh @@ -40,7 +40,7 @@ ROBOT_RUN_TESTS="${ROBOT_RUN_TESTS/,/ }" if [ ! -z "${ROBOT_HELM_PATH}" ]; then export PATH="${ROBOT_HELM_PATH}:${PATH}" fi -export PATH="${VENV_DIR}/bin:${PATH}" +export PATH="${ROBOT_VENV_DIR}/bin:${PATH}" export HELM_HOME="${ROBOT_HELM_HOME_DIR}" rm -rf ${HELM_HOME} && mkdir -p ${HELM_HOME} From c3981a2dd7950513e6032dc394069400c1509786 Mon Sep 17 00:00:00 2001 From: Marc Khouzam Date: Sun, 4 Aug 2019 21:47:26 -0400 Subject: [PATCH 2/4] Output error to dev/null Signed-off-by: Marc Khouzam Signed-off-by: Skylar Calvert --- scripts/acceptance.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/acceptance.sh b/scripts/acceptance.sh index f5d2f23..e1ba11f 100755 --- a/scripts/acceptance.sh +++ b/scripts/acceptance.sh @@ -57,7 +57,7 @@ rm -rf ${HELM_HOME} && mkdir -p ${HELM_HOME} # command will try to setup tiller on whatever cluster the user # is currently pointing to since we haven't setup the kind cluster yet. set +x -if helm version -c > /dev/null; then +if helm version -c &> /dev/null; then echo "Helm v2 not supported yet!" echo "Please set the ROBOT_HELM_PATH environment variable" \ "to the directory where the helm v3 to test can be found." From 6198f58783a08a1e25841a8de7858aea05137f03 Mon Sep 17 00:00:00 2001 From: Josh Dolitsky Date: Sun, 11 Aug 2019 23:36:59 -0500 Subject: [PATCH 3/4] Create OWNERS fixes #11 Signed-off-by: Skylar Calvert --- OWNERS | 3 +++ 1 file changed, 3 insertions(+) create mode 100644 OWNERS diff --git a/OWNERS b/OWNERS new file mode 100644 index 0000000..2a4b6b9 --- /dev/null +++ b/OWNERS @@ -0,0 +1,3 @@ +maintainers: + - jdolitsky + - marckhouzam From 648e3ba5592487b7c50aa563fc247ef803bb1d40 Mon Sep 17 00:00:00 2001 From: Skylar Calvert Date: Wed, 14 Aug 2019 21:19:56 -0500 Subject: [PATCH 4/4] Fixed #5 by Adding OS specific commands Signed-off-by: Skylar Calvert --- README.md | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/README.md b/README.md index ea889d9..5480401 100644 --- a/README.md +++ b/README.md @@ -55,12 +55,18 @@ You can use the list format of `ROBOT_RUN_TESTS` as a way to specify the order i Robot creates an HTML test report describing test successes/failures. -To view the report, runt the following: +To view the report, run the following: +####For Mac+Linux: ``` open .acceptance/report.html ``` +####For Windows: +``` +start chrome .acceptance/report.html +``` + Note: by default, the tests will output to the `.acceptance/` directory. To modify this location, set the `ROBOT_OUTPUT_DIR` environment variable.