vrnetlab version not seen within docker image

[flosch-dev]

Maybe there is already a way to identify which vrnetlab version was used to build a specific docker image. Currently the image only contains the kind and the release as docker image tag. But creating the same docker image with different vrnetlab version can result in different docker images.
Is there a way to identify which vrnetlab version was used to create the docker image? Would it make sense to somehow include the information, for example copy a simple text file and output the content as debug to stdout?

I also willing to contribute to this change, if this is useful?

[hellt]

yes, this is definitely useful
I think it should be a commit hash that is included in the boot log and can be a file (~/vrnetlab-version)

[flosch-dev]

I created a change on my fork, but before creating the PR, I wanted to check if it goes in right direction.
Now it logs the following when launch.py is started:

2024-09-23 13:00:44,559: launch     DEBUG    vrnetlab VERSION: 'Commit: 26f9d10c7f5ce72dc6e19f679cf2def58439a8b8 from Sat, 21 Sep 2024 08:50:32 +0200'

The Change is here:
flosch-dev@6c7eee7

Is commit hash + date enough?
I assume, it would need to be adapted for all other kinds manually?

[hellt]

I think the git version should be done in a common make file, not per-node one

Also the print of a version should happen from the common.py file, and not from a node specific one

[flosch-dev]

flosch-dev@732a7ab
for make file, I already used the makefile.include, which can be used by all kinds.
But still, the Dockerfile (copy the vrnetlab-version file into image) is kind specific. Also I added a func into vrnetlab, but to generate the output, launch.py needs adaption.

[flosch-dev]

How about adding a label "vrnetlab-version" to the docker container? Content can be the same as above (commit hash + commit date).
It could be done in makefile.include and would work for any kind.

            "Labels": {
                "org.opencontainers.image.authors": "[email protected]",
                "vrnetlab-version": "Commit: 26f9d10c7f5ce72dc6e19f679cf2def58439a8b8 from Sat, 21 Sep 2024 08:50:32 +0200"
            }

[hellt]

That's a good idea