You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When cursorline is enabled, ui.cursorline.primary (light-black) is very close to ui.selection.primary (gray). This can be seen in line 3 of the screenshot where it is very hard to tell that cursorline is selected in ui.cursorline.secondary.
ui.selection (light-gray) is the same color as comment (light-gray), making it impossible read secondary selections in comments.
My solution so far has been a custom theme, onedarkerest, that overrides ui.selection and ui.selection.primary to use lighter blue hues. I also experimented with overriding ui.cursorline, but didn't like those results as much.
I'm happy to submit a PR to update onedarker, but would like review from someone with a better sense of design. Are these the right colors? I just converted blue to HSV and dropped the value component. Is this the right change? Maybe there is a better ui.cursorline change?
Screenshot taken using
onedarker
theme:There are two separate contrast issues:
cursorline
is enabled,ui.cursorline.primary
(light-black
) is very close toui.selection.primary
(gray
). This can be seen in line 3 of the screenshot where it is very hard to tell thatcursorline
is selected inui.cursorline.secondary
.ui.selection
(light-gray
) is the same color ascomment
(light-gray
), making it impossible read secondary selections in comments.My solution so far has been a custom theme,
onedarkerest
, that overridesui.selection
andui.selection.primary
to use lighter blue hues. I also experimented with overridingui.cursorline
, but didn't like those results as much.I'm happy to submit a PR to update
onedarker
, but would like review from someone with a better sense of design. Are these the right colors? I just convertedblue
to HSV and dropped the value component. Is this the right change? Maybe there is a betterui.cursorline
change?Reference to current
onedarker
colors:helix/runtime/themes/onedarker.toml
Line 4 in ffdfb59
helix/runtime/themes/onedarker.toml
Lines 68 to 70 in ffdfb59
The text was updated successfully, but these errors were encountered: