Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

onedarker theme doesn't have enough contrast between ui.cursorline/ui.selection/comment #12579

Open
iliekturtles opened this issue Jan 17, 2025 · 0 comments
Labels
C-enhancement Category: Improvements

Comments

@iliekturtles
Copy link

Screenshot taken using onedarker theme:

There are two separate contrast issues:

  • When cursorline is enabled, ui.cursorline.primary (light-black) is very close to ui.selection.primary (gray). This can be seen in line 3 of the screenshot where it is very hard to tell that cursorline is selected in ui.cursorline.secondary.
  • ui.selection (light-gray) is the same color as comment (light-gray), making it impossible read secondary selections in comments.

My solution so far has been a custom theme, onedarkerest, that overrides ui.selection and ui.selection.primary to use lighter blue hues. I also experimented with overriding ui.cursorline, but didn't like those results as much.

I'm happy to submit a PR to update onedarker, but would like review from someone with a better sense of design. Are these the right colors? I just converted blue to HSV and dropped the value component. Is this the right change? Maybe there is a better ui.cursorline change?

Reference to current onedarker colors:

"comment" = { fg = "light-gray", modifiers = ["italic"] }

"ui.selection" = { bg = "light-gray" }
"ui.selection.primary" = { bg = "gray" }
"ui.cursorline.primary" = { bg = "light-black" }

@iliekturtles iliekturtles added the C-enhancement Category: Improvements label Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category: Improvements
Projects
None yet
Development

No branches or pull requests

1 participant