Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: inconsistent err messages #12577

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

fix: inconsistent err messages #12577

wants to merge 4 commits into from

Conversation

nik-rev
Copy link
Contributor

@nik-rev nik-rev commented Jan 17, 2025 •
edited
Loading

An empty picker for no diagnostics is better user experience than saying "No diagnostics", which can be interpreted as "language server is not working". Thoughts on this?

fixes #12572

@nik-rev nik-rev force-pushed the consistent-err-messages branch from f2601f9 to c2620f3 Compare January 17, 2025 15:33
@nik-rev nik-rev marked this pull request as ready for review January 17, 2025 15:33
@kirawi kirawi added C-enhancement Category: Improvements A-helix-term Area: Helix term improvements labels Jan 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-helix-term Area: Helix term improvements C-enhancement Category: Improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inconsistencies in picker opening and error messages for languge server actions
2 participants
@nik-rev @kirawi