Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use d3.scaleBand for bar & bar / line combo charts? #16

Open
clhenrick opened this issue Feb 26, 2018 · 1 comment
Open

Use d3.scaleBand for bar & bar / line combo charts? #16

clhenrick opened this issue Feb 26, 2018 · 1 comment

Comments

@clhenrick
Copy link
Contributor

clhenrick commented Feb 26, 2018 •
edited
Loading

Currently we use d3.scaleLinear and d3.scaleTime for rendering bars in both the bar and line / bar combo charts. Using d3's scaleBand would simplify implementing the bar marks and enable more granular setting of padding between bars and bar groups, however it requires re-configuring the line / bar combo chart, tooltips, etc.
@clhenrick clhenrick changed the title Use d3.scaleBand for bar chart? Use d3.scaleBand for bar & bar / line combo charts? Feb 26, 2018
@clhenrick clhenrick mentioned this issue Feb 26, 2018
Closed
@biovisualize biovisualize mentioned this issue Feb 27, 2018
Merged
@biovisualize
Copy link
Contributor

Discussion about this solution: #17 and #18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@clhenrick @biovisualize