Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spore Equality #42

Open
dlwh opened this issue Apr 19, 2016 · 4 comments
Open

Spore Equality #42

dlwh opened this issue Apr 19, 2016 · 4 comments

Comments

@dlwh
Copy link

dlwh commented Apr 19, 2016

Hi,

Nice project!

At my org, it would be convenient for us to have spores that have structural equality in the obvious way. I could imagine that you wouldn't want that to be the default, but would you entertain a PR that created a parallel EqSpore hierarchy (with EqSporeN <: SporeN, of course) that had structural equality?

@jvican
Copy link
Collaborator

jvican commented Apr 20, 2016

I know that @heathermiller and @phaller, the original creators of this project, don't have a lot of availability lately. If they don't have time for it, I could entertain that PR. Looks like a nice proposal.

@jvican
Copy link
Collaborator

jvican commented Jun 1, 2016

Are you still interested in this @dlwh ?

@dlwh
Copy link
Author

dlwh commented Jun 1, 2016

I am. I just got swamped at work and haven't had the day to do it.

One question I have if whether or not you'd be ok with all spores
implementing structural equality. If so, this is more or less trivial.
Otherwise, it requires a bit of refactoring (or code duplication...) of the
macro to make work.

On Wed, Jun 1, 2016 at 1:16 PM, Jorge [email protected] wrote:

Are you still interested in this @dlwh https://github.com/dlwh ?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#42 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AAAloYSizj9NFIs06t675XIXnCumMZ0tks5qHei1gaJpZM4ILBtl
.

@jvican
Copy link
Collaborator

jvican commented Jun 2, 2016

I'd be happy to implement it. However, I'd need some pointers on what you want exactly or what you had in mind (a simple example should work). I understand that you'd like some kind of structural equality, which sounds good, but I'd like to see also a compelling use case of it or a scenario in which it would be useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants