Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Settings modal with corrected multiple themes #186

Open
matijakljajic opened this issue Mar 28, 2024 · 2 comments
Open

[FEAT] Settings modal with corrected multiple themes #186

matijakljajic opened this issue Mar 28, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@matijakljajic
Copy link
Member

Settings modal, where you can change your preferred theme and other things regarding searching.

@matijakljajic matijakljajic added the enhancement New feature or request label Mar 28, 2024
@matijakljajic matijakljajic self-assigned this Mar 28, 2024
@aleksasiriski
Copy link
Member

In that model you should be able to pick from "session" storage vs. "local" storage, meaning that you choose if you want the theme to be only within that session or stored permanently. If the latter, you agree to "cookies" (which is only the theme preference stored in localstorage, nothing more).

@matijakljajic
Copy link
Member Author

In that model you should be able to pick from "session" storage vs. "local" storage, meaning that you choose if you want the theme to be only within that session or stored permanently. If the latter, you agree to "cookies" (which is only the theme preference stored in localstorage, nothing more).

To be more specific, it's good enough for it to be a sole checkbox which will enable localStorage that will in turn override sessionStorage if enabled. When enabled, a warning-like hint can appear below it which will say "You're agreeing for this setting to be persistent" or something like that. I believe that's good enough for it to be GDPR compliant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Todo
Development

No branches or pull requests

2 participants