Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Headlamp-server process is exposed to network in app mode #2852

Open
sniok opened this issue Feb 5, 2025 · 1 comment · May be fixed by #2876
Open

Headlamp-server process is exposed to network in app mode #2852

sniok opened this issue Feb 5, 2025 · 1 comment · May be fixed by #2876
Labels
app backend Issues related to the backend bug Something isn't working desktop Issues related to the desktop security
Milestone
v0.29.0

Comments

@sniok
Copy link
Contributor

sniok commented Feb 5, 2025

headlamp-server process that is started when you launch headlamp as a desktop app is accessible to network because it listens to "*:4466"

With in-cluster mode it's expected but in app mode it should only listen to local connection from the electron (loopback 127.0.0.1)

To Reproduce

Steps to reproduce the bug:

  1. Start the desktop app
  2. Open IP:4466/ from other device on the same network

I think to fix this issue, we need to be able to tell headlamp-server that it runs in app mode and then based on that it will listen on 127.0.0.1
@sniok sniok added app backend Issues related to the backend bug Something isn't working security labels Feb 5, 2025
@dosubot dosubot bot added the desktop Issues related to the desktop label Feb 5, 2025
@adwait-godbole
Copy link
Contributor

working on this!

@adwait-godbole adwait-godbole linked a pull request Feb 9, 2025 that will close this issue
Open
@joaquimrocha joaquimrocha added this to the v0.29.0 milestone Feb 18, 2025
@joaquimrocha joaquimrocha moved this from Queued to In Progress in Release Plan / Roadmap Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
app backend Issues related to the backend bug Something isn't working desktop Issues related to the desktop security
Projects
Release Plan / Roadmap
Status: In Progress
Milestone
v0.29.0
Development

Successfully merging a pull request may close this issue.

backend: Add app mode flag to fix network exposure adwait-godbole/headlamp
3 participants
@joaquimrocha @sniok @adwait-godbole