Update to Sahi v5

[sriv]

Rebase to sahi v5.0

[globalworming]

Hey sriv,

we already started moving the changes from r2286 to r2294 of http://sourceforge.net/p/sahi/code/commit_browser but due to other issues we won't get around finishing what we did for a while, so any help is appreciated. See https://github.com/headissue/Sahi/tree/sahi-os-5-integration for what was already done.
We may get around this in a month or two, I hope that's ok for you.

Regards
globalworming

[sriv]

Hey globalworming,

Good to see you working on this. I and @prateekbaheti could possibly help out. Could you elaborate on what problems you are facing?

Keep up the good work!
--sriv

[globalworming]

That would be great!

We have no real problems with the migration so far. It's just that other projects take up all our resources.

What we did is just taking all diffs from http://sourceforge.net/p/sahi/code/commit_browser and applying them to our project. We usually drop Windows and Mac related code to focus on Linux because we don't have the time and nerve to test Sahi properly on Windows and Mac machines. That's a problem we may address later.

For now its just manually going through all changed files and copy-pasting the changes. I'm happy about everyone getting involved in this :) Just fork this project, check out https://github.com/headissue/Sahi/tree/sahi-os-5-integration and continue migrating if you like. And if any questions arise, feel free to ask.

[arne-vandamme]

Hey @globalworming,

I might be interested in helping out merging the changes from Sahi 5 as well. Unfortunately only bumped into this project today but have been looking for an actively maintained Sahi open source. I'd be willing to help out as we're actively using Sahi in our own framework and might be wanting to do some customization and improvements.

I had a quick check and did notice you have diverged quite a lot already from the original Sahi 44, so perhaps you can shed some light on the some of my questions:

• Windows support is quite crucial for us, can you tell me how much of that compatibility have you dropped over time? Was it only not migrating Windows specific files or actual code modifications as well ? Are you willing to bring support for Windows back in (meaning: can i put back the files I require, make test changes to run on Windows etc).
• The JDK 8 dependency, is there any way this could be downscaled to 7? I need to integrate the sahi jar in JDK 7 projects that cannot upgrade yet, but i don't know how far the dependency goes.
• For commits: can you share a code style settings file (intellij 14?).

For the record: we're only interested in Sahi as a proxy and client java library, not the recorder functionality. So would not be putting any effort into that.

I also run into a couple of issues with the unit tests when trying to build, however these might be due to Windows setup. I'll only bother you with those questions if it's interesting to continue :)

[arne-vandamme]

Looked around the code a bit more:

• looks like removing dependency on JDK 8 is not an option. I mainly require the client part of Sahi to be jdk 7 compliant. Perhaps the jar can be compiled with JDK 7 compatibility (or alternatively we could think of separating client into a separate jar). Without looking into detail, I'm pretty sure the client doesn't invoke the scriptrunner directly.
• Also looks like you cleaned out Windows support thoroughly. My question remains however: open to bring it back to some extent?

[globalworming]

Also looks like you cleaned out Windows support thoroughly. My question remains however: open to bring it back to some extent?

Sure, I'd love to see Sahi OS for all operating systems, but as I said, we don't have/want the machines to test Sahi. All the windows files and switches can be restored and I would be glad to help with that, but I don't want to get involved in issues like "Sahi not running with Windows 8.1 IE 12".

can you share a code style settings file (intellij 14?)

Done with 677221e

or alternatively we could think of separating client into a separate jar

Only the server side needs Nashorn. If its just for invoking scripts, look into the testrunner module. Sahi/sahi-test-runner This is for invoking tests on a Sahi Proxy via openStream()

[arne-vandamme]

Okay, I'd try to look into how much of a fit this project could be for us in the next couple of days.
We're currently using our own (very lightly) customized version of Sahi 4.4, so will take a bit to look over the changes (including the ones from v5).

Will keep you posted and thanks already.

[arne-vandamme]

Hey, just a little feedback from my end. After looking into the migration effort required we decided to move forward with our own custom SAHI implementation based on OS 5, mainly because it allowed us to move faster.

I'll definitely be following the improvements you make over time, to see if at one point in time it might be beneficial to move back to one maintained line.

[rahulmr]

@arne-vandamme Is it possible to share your code on github if it is open source?

After looking into the migration effort required we decided to move forward with our own custom SAHI implementation based on OS 5, mainly because it allowed us to move faster.

[arne-vandamme]

It has been several years since I worked on this, and we no longer continue any development with Sahi. But all the changes I did back then are available at https://github.com/arne-vandamme/Sahi/commits/master.

I think this is the latest version we actually used: https://github.com/arne-vandamme/Sahi/commits/sahi-5.0

Maybe it can still be useful for you.