Skip to content

Commit b7f205f

Browse files
committed
Update docker building process pkiraly#267
1 parent 6cc980e commit b7f205f

File tree

6 files changed

+29
-17
lines changed

6 files changed

+29
-17
lines changed

Dockerfile

+24-12
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,8 @@ LABEL maintainer="Péter Király <[email protected]>, Ákos Takács <rimelek@rimel
44

55
LABEL description="QA catalogue - a metadata quality assessment tool for MARC based library catalogues."
66

7-
ARG QA_CATALOGUE_VERSION=0.6.0
7+
ARG QA_CATALOGUE_VERSION=0.7.0-rc1
8+
ARG QA_CATALOGUE_WEB_VERSION=0.7.0-rc1
89
ARG DEBIAN_FRONTEND=noninteractive
910
ARG SMARTY_VERSION=3.1.44
1011
ARG SOLR_VERSION=8.11.1
@@ -27,6 +28,7 @@ RUN apt-get update \
2728
nano \
2829
jq \
2930
curl \
31+
wget \
3032
openssl \
3133
# install Java
3234
openjdk-11-jre-headless \
@@ -50,37 +52,47 @@ RUN cd /opt \
5052
&& mv metadata-qa-marc-${QA_CATALOGUE_VERSION} metadata-qa-marc \
5153
&& mv /opt/metadata-qa-marc/setdir.sh.template /opt/metadata-qa-marc/setdir.sh \
5254
&& mkdir -p /opt/metadata-qa-marc/marc \
53-
&& sed -i.bak 's,BASE_INPUT_DIR=your/path,BASE_INPUT_DIR=/opt/metadata-qa-marc/marc,' /opt/metadata-qa-marc/setdir.sh \
54-
&& sed -i.bak 's,BASE_OUTPUT_DIR=your/path,BASE_OUTPUT_DIR=/opt/metadata-qa-marc/marc/_output,' /opt/metadata-qa-marc/setdir.sh \
55+
&& sed -i.bak 's,BASE_INPUT_DIR=./input,BASE_INPUT_DIR=/opt/metadata-qa-marc/marc,' /opt/metadata-qa-marc/setdir.sh \
56+
&& sed -i.bak 's,BASE_OUTPUT_DIR=./output,BASE_OUTPUT_DIR=/opt/metadata-qa-marc/marc/_output,' /opt/metadata-qa-marc/setdir.sh \
5557
# install web application
5658
&& apt-get update \
5759
&& apt-get install -y --no-install-recommends \
5860
apache2 \
5961
php \
6062
php-sqlite3 \
63+
php-curl \
6164
unzip \
65+
composer \
6266
&& rm -rf /var/lib/apt/lists/* \
6367
&& cd /var/www/html/ \
64-
&& curl -s -L https://github.com/pkiraly/metadata-qa-marc-web/archive/refs/heads/main.zip --output master.zip \
65-
# && curl -s -L https://github.com/pkiraly/metadata-qa-marc-web/archive/0.4.zip --output master.zip \
68+
# && curl -s -L https://github.com/pkiraly/metadata-qa-marc-web/archive/refs/heads/main.zip --output master.zip \
69+
# && curl -s -L https://github.com/pkiraly/metadata-qa-marc-web/archive/${QA_CATALOGUE_VERSION}.zip --output master.zip \
70+
&& curl -s -L https://github.com/pkiraly/metadata-qa-marc-web/archive/refs/tags/v${QA_CATALOGUE_WEB_VERSION}.zip --output master.zip \
71+
&& ls -la \
6672
&& unzip -q master.zip \
6773
&& rm master.zip \
6874
# && mv metadata-qa-marc-web-0.4 metadata-qa \
69-
&& mv metadata-qa-marc-web-main metadata-qa \
75+
&& mv metadata-qa-marc-web-${QA_CATALOGUE_WEB_VERSION} metadata-qa \
76+
&& cd metadata-qa \
77+
&& composer install \
7078
&& echo dir=/opt/metadata-qa-marc/marc/_output > /var/www/html/metadata-qa/configuration.cnf \
7179
# && cp /var/www/html/metadata-qa/configuration.js.template /var/www/html/metadata-qa/configuration.js \
7280
&& touch /var/www/html/metadata-qa/selected-facets.js \
7381
&& mkdir /var/www/html/metadata-qa/cache \
7482
&& chown www-data:www-data -R /var/www/html/metadata-qa/cache \
7583
&& chmod g+w -R /var/www/html/metadata-qa/cache \
84+
&& touch cache/selected-facets.js \
85+
&& mkdir _smarty \
86+
&& chgrp www-data -R _smarty \
87+
&& chmod g+w -R _smarty \
7688
&& mkdir /var/www/html/metadata-qa/libs \
7789
&& mkdir /var/www/html/metadata-qa/images \
78-
&& cd /var/www/html/metadata-qa/libs/ \
79-
&& curl -s -L https://github.com/smarty-php/smarty/archive/v${SMARTY_VERSION}.zip --output v$SMARTY_VERSION.zip \
80-
&& unzip -q v${SMARTY_VERSION}.zip \
81-
&& rm v${SMARTY_VERSION}.zip \
82-
&& mkdir -p /var/www/html/metadata-qa/libs/_smarty/templates_c \
83-
&& chmod a+w -R /var/www/html/metadata-qa/libs/_smarty/templates_c/ \
90+
# && cd /var/www/html/metadata-qa/libs/ \
91+
# && curl -s -L https://github.com/smarty-php/smarty/archive/v${SMARTY_VERSION}.zip --output v$SMARTY_VERSION.zip \
92+
# && unzip -q v${SMARTY_VERSION}.zip \
93+
# && rm v${SMARTY_VERSION}.zip \
94+
# && mkdir -p /var/www/html/metadata-qa/libs/_smarty/templates_c \
95+
# && chmod a+w -R /var/www/html/metadata-qa/libs/_smarty/templates_c/ \
8496
&& sed -i.bak 's,</VirtualHost>, RedirectMatch ^/$ /metadata-qa/\n <Directory /var/www/html/metadata-qa>\n Options Indexes FollowSymLinks MultiViews\n AllowOverride All\n Order allow\,deny\n allow from all\n DirectoryIndex index.php index.html\n </Directory>\n</VirtualHost>,' /etc/apache2/sites-available/000-default.conf \
8597
&& echo "\nWEB_DIR=/var/www/html/metadata-qa/\n" >> /opt/metadata-qa-marc/common-variables
8698

common-variables

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
1-
VERSION=0.7.0-SNAPSHOT
1+
VERSION=0.7.0-rc1
22
JAR=target/metadata-qa-marc-${VERSION}-jar-with-dependencies.jar
33
DIR=.

pom.xml

+1-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
<groupId>de.gwdg.metadataqa</groupId>
66
<artifactId>metadata-qa-marc</artifactId>
77
<packaging>jar</packaging>
8-
<version>0.7.0-SNAPSHOT</version>
8+
<version>0.7.0-rc1</version>
99
<name>Quality assessment for MARC</name>
1010
<description>
1111
A metadata quality assessment framework for MARC21 records.

src/test/java/de/gwdg/metadataqa/marc/cli/CompletenessTest.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -313,7 +313,7 @@ public void completeness_pica_groupBy_file() throws Exception {
313313
assertTrue(line.contains("\"replacementInControlFields\":null,"));
314314
assertTrue(line.contains("\"marc21\":false,"));
315315
assertTrue(line.contains("\"mqaf.version\":\"1.0.0-SNAPSHOT\","));
316-
assertTrue(line.contains("\"qa-catalogue.version\":\"0.7.0-SNAPSHOT\"}"));
316+
assertTrue(line.contains("\"qa-catalogue.version\":\"0.7.0-rc1\"}"));
317317

318318
} else if (outputFile.equals("libraries.csv")) {
319319
output = new File(outputDir, outputFile);

src/test/java/de/gwdg/metadataqa/marc/cli/ValidatorCliTest.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -244,7 +244,7 @@ public void validate_pica_groupBy() throws Exception {
244244
assertTrue(line.contains("\"replacementInControlFields\":null,"));
245245
assertTrue(line.contains("\"marc21\":false,"));
246246
assertTrue(line.contains("\"mqaf.version\":\"1.0.0-SNAPSHOT\","));
247-
assertTrue(line.contains("\"qa-catalogue.version\":\"0.7.0-SNAPSHOT\"}"));
247+
assertTrue(line.contains("\"qa-catalogue.version\":\"0.7.0-rc1\"}"));
248248

249249
} else {
250250
fail("Untested output file: " + outputFile);

src/test/java/de/gwdg/metadataqa/marc/cli/VersionTest.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66

77
public class VersionTest {
88

9-
private static final String VERSION = "0.7.0-SNAPSHOT";
9+
private static final String VERSION = "0.7.0-rc1";
1010

1111
@Test
1212
public void getVersion() {

0 commit comments

Comments
 (0)